Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(944)

Unified Diff: omaha_request_action_unittest.cc

Issue 6253002: AU: XmlEncode the previous version, just in case. (Closed) Base URL: ssh://git@gitrw.chromium.org:9222/update_engine.git@master
Patch Set: Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « omaha_request_action.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: omaha_request_action_unittest.cc
diff --git a/omaha_request_action_unittest.cc b/omaha_request_action_unittest.cc
index 8082e1567f237eedfc40a96ca825364eb097eec2..7e67555f592f4a57466bd47fc78324c9d5819e68 100755
--- a/omaha_request_action_unittest.cc
+++ b/omaha_request_action_unittest.cc
@@ -546,7 +546,7 @@ TEST(OmahaRequestActionTest, FormatUpdateCheckPrevVersionOutputTest) {
vector<char> post_data;
NiceMock<PrefsMock> prefs;
EXPECT_CALL(prefs, GetString(kPrefsPreviousVersion, _))
- .WillOnce(DoAll(SetArgumentPointee<1>(string("1.2.3.4")), Return(true)));
+ .WillOnce(DoAll(SetArgumentPointee<1>(string("1.2>3.4")), Return(true)));
EXPECT_CALL(prefs, SetString(kPrefsPreviousVersion, ""))
.WillOnce(Return(true));
ASSERT_FALSE(TestUpdateCheck(&prefs,
@@ -565,7 +565,7 @@ TEST(OmahaRequestActionTest, FormatUpdateCheckPrevVersionOutputTest) {
string::npos);
string prev_version_event = StringPrintf(
" <o:event eventtype=\"%d\" eventresult=\"%d\" "
- "previousversion=\"1.2.3.4\"></o:event>\n",
+ "previousversion=\"1.2&gt;3.4\"></o:event>\n",
OmahaEvent::kTypeUpdateComplete,
OmahaEvent::kResultSuccessReboot);
EXPECT_NE(post_str.find(prev_version_event), string::npos);
« no previous file with comments | « omaha_request_action.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698