Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Unified Diff: chrome/browser/autocomplete/autocomplete_edit_view_gtk.h

Issue 6252003: Accept keyword by pressing space. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix a bug on Windows when using an IME. Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autocomplete/autocomplete_edit_view_gtk.h
diff --git a/chrome/browser/autocomplete/autocomplete_edit_view_gtk.h b/chrome/browser/autocomplete/autocomplete_edit_view_gtk.h
index 190fa276298b6e0c6d480b5f720ee4265279ac40..1fa83171017c1ef35bad6bcc8b2f53b15dfa6ed0 100644
--- a/chrome/browser/autocomplete/autocomplete_edit_view_gtk.h
+++ b/chrome/browser/autocomplete/autocomplete_edit_view_gtk.h
@@ -64,6 +64,9 @@ class AutocompleteEditViewGtk : public AutocompleteEditView,
int selection_min() const { return std::min(cp_min, cp_max); }
int selection_max() const { return std::max(cp_min, cp_max); }
+ // Returns true if the range is empty.
+ bool empty() const { return cp_min == cp_max; }
+
// Work in integers to match the gint GTK APIs.
int cp_min; // For a selection: Represents the start.
int cp_max; // For a selection: Represents the end (insert position).
@@ -185,13 +188,6 @@ class AutocompleteEditViewGtk : public AutocompleteEditView,
bool CommitInstantSuggestion();
- // Used by LocationBarViewGtk to inform AutocompleteEditViewGtk if the tab to
- // search should be enabled or not. See the comment of |enable_tab_to_search_|
- // for details.
- void set_enable_tab_to_search(bool enable) {
- enable_tab_to_search_ = enable;
- }
-
GtkWidget* text_view() {
return text_view_;
}
@@ -495,11 +491,6 @@ class AutocompleteEditViewGtk : public AutocompleteEditView,
// is needed.
CharRange strikethrough_;
- // Indicate if the tab to search should be enabled or not. It's true by
- // default and will only be set to false if the location bar view is not able
- // to show the tab to search hint.
- bool enable_tab_to_search_;
-
// Indicates if the selected text is suggested text or not. If the selection
// is not suggested text, that means the user manually made the selection.
bool selection_suggested_;

Powered by Google App Engine
This is Rietveld 408576698