Issue 6251004: Sync: Clean up fake URLFetcher factory prior to browser shut down

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6251004: Sync: Clean up fake URLFetcher factory prior to browser shut down (Closed)

Created:
9 years, 11 months ago by Raghu Simha

Modified:
9 years, 7 months ago

Reviewers:
akalin

CC:
chromium-reviews, Raghu Simha, ncarter (slow), idana, tim (not reviewing), Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Sync: Clean up fake URLFetcher factory prior to browser shut down Revision 71253 introduced a fake URLFetcher factory to the sync tests. The clean up step of reverting to the default URLFetcher was added to LiveSyncTest::TearDown(), which is run after browser shut down. The correct place to add the clean up step is the method LiveSyncTest::TearDownInProcessBrowserTestFixture(), which is run prior to browser shut down. This patch merely moves the clean up step to the right spot. TBR=akalin@chromium.org BUG=69184, 56729, 53931 TEST=sync_integration_tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71392

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	chrome/test/live_sync/live_sync_test.cc	View		2 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

akalin

9 years, 11 months ago (2011-01-14 00:27:56 UTC) #2

LGTM

On 2011/01/13 23:58:44, rsimha wrote:
> Fred, please review. Thanks.

Expand Messages | Collapse Messages