Issue 6251003: Revert "Revert "Use libcros to convert input method ID to keyboard overlay ID.""

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6251003: Revert "Revert "Use libcros to convert input method ID to keyboard overlay ID."" (Closed)

Created:
9 years, 11 months ago by mazda

Modified:
9 years, 7 months ago

Reviewers:
satorux1

CC:
chromium-reviews, pam+watch_chromium.org, davemoore+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Revert "Revert "Use libcros to convert input method ID to keyboard overlay ID."" I also modified mock_input_method_libary.h to avoid the build error of unit_tests. This reverts commit e9c1551065d06d47b024898bf75e8d6854aa760b. BUG=chromium-os:9682 TEST='emerge-x86-generic chromeos-chrome' from source passes Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71294

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+103 lines, -97 lines)			Patch
M	chrome/browser/chromeos/cros/input_method_library.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/cros/input_method_library.cc	View	4 chunks	+93 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/cros/mock_input_method_library.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/chromeos/dom_ui/keyboard_overlay_ui.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/input_method_util.cc	View	5 chunks	+1 line, -19 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/input_method_util_unittest.cc	View	1 chunk	+0 lines, -74 lines	0 comments	Download
M	tools/cros.DEPS/DEPS	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

mazda

Can you look at the second trial of the change to use libcros, which was ...

9 years, 11 months ago (2011-01-13 03:58:02 UTC) #1

LGTM

Expand Messages | Collapse Messages