WebUI: Fix middle click link issue in click handler

WebUI: Fix middle click link issue in click handler

This makes sure we do not open a link twice (once due to the handler and once
due to the browser behavior).

BUG=None
TEST=None

[arv (Not doing code reviews), 2011-02-07 23:40:38]

Evan, is there a bug for this already?

I could not find an existing place where we have a file/about URL in a DOMUI. I
added one manually but it would be good to know if there is one so that QA can
verify.

[Evan Stade, 2011-02-08 00:00:59]

there's no bug filed for it. There's an about: link in advanced->content
settings->plugins section

why did you change it to prevent the default even when not taking any action?

[arv (Not doing code reviews), 2011-02-08 00:30:11]

On 2011/02/08 00:00:59, Evan Stade wrote:
> there's no bug filed for it. There's an about: link in advanced->content
> settings->plugins section
> 
> why did you change it to prevent the default even when not taking any action?

Since we are handling file: and about: URLs we need to make sure that we don't
do the default action for these. For example, we are handling middle click in
mouseup so we need to prevent the default action in click.

[Evan Stade, 2011-02-08 00:54:51]

If the default is to navigate on 'click' for middle button, I think we want to
handle 'click' rather than 'mouseup'.

If the default is to navigate on 'mouseup' for middle button, we don't care
about preventing default for 'click'.

[arv (Not doing code reviews), 2011-02-08 01:00:57]

If we are fine tracking the WebKit bug than we should just use click.

erik








On Mon, Feb 7, 2011 at 16:54,  <estade@chromium.org> wrote:
> If the default is to navigate on 'click' for middle button, I think we want
> to
> handle 'click' rather than 'mouseup'.
>
> If the default is to navigate on 'mouseup' for middle button, we don't care
> about preventing default for 'click'.
>
> http://codereview.chromium.org/6250207/
>

[Evan Stade, 2011-02-08 01:08:47]

yea, I think that is fine. We'd need to update this after the webkit bug gets
resolved anyway (assuming the behavior does change again) because mouseup is
slightly different from click.

[arv (Not doing code reviews), 2011-02-08 01:12:38]

OK. I'll reply to this thread when the code is ready for review again.

erik

On Mon, Feb 7, 2011 at 17:08,  <estade@chromium.org> wrote:
> yea, I think that is fine. We'd need to update this after the webkit bug
> gets
> resolved anyway (assuming the behavior does change again) because mouseup is
> slightly different from click.
>
> http://codereview.chromium.org/6250207/
>

[arv (Not doing code reviews), 2011-02-16 02:32:29]

PTAL

[Evan Stade, 2011-02-16 02:50:57]

lgtm

(p.s. does this work for keyboard activation?)

[arv (Not doing code reviews), 2011-02-16 18:50:10]

A focused link triggers a click event (with button=0) when you press enter.

erik








On Tue, Feb 15, 2011 at 18:50,  <estade@chromium.org> wrote:
> lgtm
>
> (p.s. does this work for keyboard activation?)
>
> http://codereview.chromium.org/6250207/
>