Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1172)

Unified Diff: chrome/common/net/test_url_fetcher_factory.h

Issue 6250198: More out-of-lining of test code, along with a bunch of GMOCK objects. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Really fix the gyp files this time Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/net/test_url_fetcher_factory.h
diff --git a/chrome/common/net/test_url_fetcher_factory.h b/chrome/common/net/test_url_fetcher_factory.h
index 73f4b460837c22a2452bf594a44720ae431caa43..65625a40907d215dd15d275554b72dd6911d94b1 100644
--- a/chrome/common/net/test_url_fetcher_factory.h
+++ b/chrome/common/net/test_url_fetcher_factory.h
@@ -76,7 +76,8 @@ class TestURLFetcher : public URLFetcher {
// are registered in a map by the id passed to the create method.
class TestURLFetcherFactory : public URLFetcher::Factory {
public:
- TestURLFetcherFactory() {}
+ TestURLFetcherFactory();
+ virtual ~TestURLFetcherFactory();
virtual URLFetcher* CreateURLFetcher(int id,
const GURL& url,
@@ -128,7 +129,8 @@ class TestURLFetcherFactory : public URLFetcher::Factory {
class FakeURLFetcherFactory : public URLFetcher::Factory {
public:
- FakeURLFetcherFactory() {}
+ FakeURLFetcherFactory();
+ virtual ~FakeURLFetcherFactory();
// If no fake response is set for the given URL this method will return NULL.
// Otherwise, it will return a URLFetcher object which will respond with the

Powered by Google App Engine
This is Rietveld 408576698