Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 6250197: Allow explicit object registration. (Closed)

Created:
9 years, 10 months ago by Elly Fong-Jones
Modified:
9 years, 4 months ago
Reviewers:
Jason Glasgow
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

Allow explicit object registration. This also allows explicit object *un*registration, which means that the object lifecycle (as exposed to the bus) is now divorced from the object lifecycle as a C++ object. This allows things like e.g. unregistering an object now but running its cleanup "later". BUG=chromium-os:9628 TEST=Adhoc Built, ran, connected to 3G. Change-Id: Icfdb96ff47bb6a0d5e86a0774981906f20304c88 Signed-off-by: Elly Jones <ellyjones@chromium.org>; Signed-off-by: Jason Glasgow <jglasgow@chromium.org>; Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=f5a3f7a

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -7 lines) Patch
M include/dbus-c++/object.h View 3 chunks +13 lines, -7 lines 1 comment Download
M src/object.cpp View 3 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Elly Fong-Jones
9 years, 10 months ago (2011-02-07 19:13:56 UTC) #1
Jason Glasgow
9 years, 10 months ago (2011-02-07 20:00:48 UTC) #2
LGTM

http://codereview.chromium.org/6250197/diff/1/include/dbus-c++/object.h
File include/dbus-c++/object.h (right):

http://codereview.chromium.org/6250197/diff/1/include/dbus-c++/object.h#newco...
include/dbus-c++/object.h:56: virtual void register_obj() = 0;
As discussed, exposing register_obj() does not really help because it is always
called in the constructor.  A case could be made for a constructor that does not
call register_obj() and allows one to invoke register_obj() when appropriate.

No need to change this CL.  We can add that functionality when needed.

Powered by Google App Engine
This is Rietveld 408576698