Issue 6250188: Roll clang to r124477.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6250188: Roll clang to r124477. (Closed)

Created:
9 years, 10 months ago by Nico

Modified:
9 years, 7 months ago

Reviewers:
hans, Evan Martin

CC:
chromium-reviews, pam+watch_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Roll clang to r124477. Also reenable OVERRIDE. BUG=71088 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=73994

Patch Set 1 #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -4 lines)			Patch
	M	base/compiler_specific.h	View		1 chunk	+2 lines, -3 lines	0 comments	Download
	M	tools/clang/scripts/update.sh	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Nico

This patch was tested by sending it to the linux_clang and mac_clang trybots!

9 years, 10 months ago (2011-02-07 03:39:22 UTC) #1

Evan Martin

9 years, 10 months ago (2011-02-07 16:38:22 UTC) #2

rubber stamp

On Sun, Feb 6, 2011 at 7:39 PM,  <thakis@chromium.org> wrote:
> Reviewers: Evan Martin, hans,
>
> Message:
> This patch was tested by sending it to the linux_clang and mac_clang
> trybots!
>
> Description:
> Roll clang to r124477.
>
> Also reenable OVERRIDE.
>
> BUG=71088
> TEST=none
>
> Please review this at http://codereview.chromium.org/6250188/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>  M base/compiler_specific.h
>  M tools/clang/scripts/update.sh
>
>
> Index: base/compiler_specific.h
> diff --git a/base/compiler_specific.h b/base/compiler_specific.h
> index
>
fd2b083f1b7c4b8e45ad79a559a058e9b1cd62be..30603065b7004353a7e1d350eb4c276952e7565a
> 100644
> --- a/base/compiler_specific.h
> +++ b/base/compiler_specific.h
> @@ -84,9 +84,8 @@
>  //   virtual void foo() OVERRIDE;
>  #if defined(COMPILER_MSVC)
>  #define OVERRIDE override
> -// TODO(thakis): Reenable this, http://crbug.com/71088
> -//#elif defined(__clang__)
> -//#define OVERRIDE __attribute__((override))
> +#elif defined(__clang__)
> +#define OVERRIDE override
>  #else
>  #define OVERRIDE
>  #endif
> Index: tools/clang/scripts/update.sh
> diff --git a/tools/clang/scripts/update.sh b/tools/clang/scripts/update.sh
> index
>
256b999bbb93e23d7d2c1b193b6c2829764c6a6c..b9ebad96ca193570404ae27d26e9374e2e4e678e
> 100755
> --- a/tools/clang/scripts/update.sh
> +++ b/tools/clang/scripts/update.sh
> @@ -5,7 +5,7 @@
>
>  # This script will check out llvm and clang into third_party/llvm and build
> it.
>
> -CLANG_REVISION=124227
> +CLANG_REVISION=124477
>
>  THIS_DIR=$(dirname $0)
>  LLVM_DIR=$THIS_DIR/../../../third_party/llvm
>
>
>

Expand Messages | Collapse Messages