Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(608)

Unified Diff: chrome/renderer/safe_browsing/phishing_dom_feature_extractor.cc

Issue 6250176: Make RenderView not have to know about how PhishingClassifierDelegate. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: sync Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/safe_browsing/phishing_dom_feature_extractor.cc
===================================================================
--- chrome/renderer/safe_browsing/phishing_dom_feature_extractor.cc (revision 73993)
+++ chrome/renderer/safe_browsing/phishing_dom_feature_extractor.cc (working copy)
@@ -146,11 +146,7 @@
if (!cur_frame_) {
WebKit::WebView* web_view = render_view_->webview();
if (!web_view) {
- // When the WebView is going away, the render view should have called
- // CancelPendingExtraction() which should have stopped any pending work,
- // so this case should not happen.
- NOTREACHED();
- RunCallback(false);
+ RunCallback(false); // The WebView is going away.
Brian Ryner 2011/02/07 20:08:19 We're not using it currently, but there is a simil
jam 2011/02/07 20:24:49 Done.
return;
}
cur_frame_ = web_view->mainFrame();

Powered by Google App Engine
This is Rietveld 408576698