Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4200)

Unified Diff: chrome/renderer/safe_browsing/phishing_thumbnailer.cc

Issue 6250176: Make RenderView not have to know about how PhishingClassifierDelegate. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/safe_browsing/phishing_dom_feature_extractor.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/safe_browsing/phishing_thumbnailer.cc
===================================================================
--- chrome/renderer/safe_browsing/phishing_thumbnailer.cc (revision 73993)
+++ chrome/renderer/safe_browsing/phishing_thumbnailer.cc (working copy)
@@ -28,8 +28,7 @@
const gfx::Size& view_size,
const gfx::Size& thumbnail_size) {
if (!render_view || !render_view->webview()) {
- NOTREACHED();
- return SkBitmap();
+ return SkBitmap(); // The WebView is going away.
}
WebView* view = render_view->webview();
base::TimeTicks beginning_time = base::TimeTicks::Now();
« no previous file with comments | « chrome/renderer/safe_browsing/phishing_dom_feature_extractor.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698