Issue 6250135: [SYNC] Fix handling of password store corruption.

Issue 6250135: [SYNC] Fix handling of password store corruption. (Closed)

Created:
9 years, 10 months ago by Nicolas Zea

Modified:
9 years, 7 months ago

Reviewers:
tim (not reviewing)

CC:
chromium-reviews, Raghu Simha, ncarter (slow), idana, tim (not reviewing), Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

[SYNC] Fix handling of password store corruption. BUG=70849 TEST=sync successfully once, shut down, corrupt the password store db, start up, make sure we don't crash Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=73754

Patch Set 1 #

Total comments: 2

Patch Set 2 : Yep. #

Patch Set 3 : Self review #

Patch Set 4 : Another rearrange of code #

Patch Set 5 : Fix tests. #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -12 lines)			Patch
M	chrome/browser/sync/glue/password_data_type_controller.cc	View	1 2 3	2 chunks	+10 lines, -3 lines	0 comments	Download
M	chrome/browser/sync/glue/sync_backend_host.cc	View	1	2 chunks	+9 lines, -8 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_service_password_unittest.cc	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Nicolas Zea

There appears to still be some issue with attempting to sync after this happens, but ...

9 years, 10 months ago (2011-02-03 20:55:44 UTC) #1

tim (not reviewing)

http://codereview.chromium.org/6250135/diff/1/chrome/browser/sync/glue/sync_backend_host.cc File chrome/browser/sync/glue/sync_backend_host.cc (right): http://codereview.chromium.org/6250135/diff/1/chrome/browser/sync/glue/sync_backend_host.cc#newcode129 chrome/browser/sync/glue/sync_backend_host.cc:129: registrar_.routing_info.remove(syncable::PASSWORDS); You want .erase I think.

9 years, 10 months ago (2011-02-03 21:10:29 UTC) #3

Nicolas Zea

9 years, 10 months ago (2011-02-03 22:53:56 UTC) #4

Fixed. Also fixed another potential issue due to the callback being copied into
a scoped pointer.

http://codereview.chromium.org/6250135/diff/1/chrome/browser/sync/glue/sync_b...
File chrome/browser/sync/glue/sync_backend_host.cc (right):

http://codereview.chromium.org/6250135/diff/1/chrome/browser/sync/glue/sync_b...
chrome/browser/sync/glue/sync_backend_host.cc:129:
registrar_.routing_info.remove(syncable::PASSWORDS);
On 2011/02/03 21:10:29, timsteele wrote:
> You want .erase I think.

Done.

Expand Messages | Collapse Messages