Issue 6250126: ARM: Add support for and, or and xor to the type recording binary op stub.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6250126: ARM: Add support for and, or and xor to the type recording binary op stub. (Closed)

Created:
9 years, 10 months ago by Søren Thygesen Gjesse

Modified:
9 years, 7 months ago

Reviewers:
Karl Klose

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

ARM: Add support for and, or and xor to the type recording binary op stub. Committed: http://code.google.com/p/v8/source/detail?r=6631

Patch Set 3 : '' #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+308 lines, -102 lines)			Patch
M	src/arm/code-stubs-arm.cc	View	1 2	14 chunks	+262 lines, -90 lines	0 comments	Download
M	src/arm/codegen-arm.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/arm/full-codegen-arm.cc	View		1 chunk	+4 lines, -1 line	0 comments	Download
M	src/arm/lithium-arm.cc	View		2 chunks	+19 lines, -6 lines	0 comments	Download
M	src/arm/macro-assembler-arm.h	View		2 chunks	+8 lines, -1 line	0 comments	Download
M	src/arm/macro-assembler-arm.cc	View		2 chunks	+14 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Karl Klose

LGTM. http://codereview.chromium.org/6250126/diff/4001/src/arm/code-stubs-arm.cc File src/arm/code-stubs-arm.cc (right): http://codereview.chromium.org/6250126/diff/4001/src/arm/code-stubs-arm.cc#newcode543 src/arm/code-stubs-arm.cc:543: Label* not_number) { not_number -> not_int32? http://codereview.chromium.org/6250126/diff/4001/src/arm/code-stubs-arm.cc#newcode2680 src/arm/code-stubs-arm.cc:2680: ...

9 years, 10 months ago (2011-02-04 10:19:23 UTC) #2

Søren Thygesen Gjesse

9 years, 10 months ago (2011-02-04 10:40:50 UTC) #3

http://codereview.chromium.org/6250126/diff/4001/src/arm/code-stubs-arm.cc
File src/arm/code-stubs-arm.cc (right):

http://codereview.chromium.org/6250126/diff/4001/src/arm/code-stubs-arm.cc#ne...
src/arm/code-stubs-arm.cc:543: Label* not_number) {
On 2011/02/04 10:19:23, Karl Klose wrote:
> not_number -> not_int32?

Done.

http://codereview.chromium.org/6250126/diff/4001/src/arm/code-stubs-arm.cc#ne...
src/arm/code-stubs-arm.cc:2680: __ push(lr);  // For later.
On 2011/02/04 10:19:23, Karl Klose wrote:
> Where is it used later?

There is a pop(pc) below to return. I have updated the comments to clarify this.

Expand Messages | Collapse Messages

Issue 6250126: ARM: Add support for and, or and xor to the type recording binary op stub. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Messages