Issue 6250125: Update the dynamic annotations to the trunk version from...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6250125: Update the dynamic annotations to the trunk version from... (Closed)

Created:
9 years, 10 months ago by Alexander Potapenko

Modified:
9 years, 6 months ago

Reviewers:
Lei Zhang, Timur Iskhodzhanov

CC:
chromium-reviews, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Update the dynamic annotations to the trunk version from http://code.google.com/p/data-race-test This is necessary to build Chromium with a custom annotations prefix in order to link it against ThreadSanitizer runtime library. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=73794

Patch Set 1 #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+266 lines, -176 lines)			Patch
	M	base/third_party/dynamic_annotations/dynamic_annotations.h	View		14 chunks	+188 lines, -109 lines	0 comments	Download
	M	base/third_party/dynamic_annotations/dynamic_annotations.c	View		2 chunks	+78 lines, -67 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Timur Iskhodzhanov

This is just a copy-paste from the upstream files? If so - LGTM

9 years, 10 months ago (2011-02-03 19:49:22 UTC) #2

Alexander Potapenko

9 years, 10 months ago (2011-02-04 10:43:05 UTC) #3

On 2011/02/03 19:49:22, Timur Iskhodzhanov wrote:
> This is just a copy-paste from the upstream files?
> If so - LGTM

Yes, with the respect to #include filenames.

Expand Messages | Collapse Messages