Issue 6250116: Avoid problems where PW prompt in enter_chroot.sh would block other terminals.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6250116: Avoid problems where PW prompt in enter_chroot.sh would block other terminals. (Closed)

Created:
9 years, 10 months ago by diandersAtChromium

Modified:
9 years, 6 months ago

Reviewers:
anush

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
ssh://git@gitrw.chromium.org:9222/crosutils.git@master

Visibility:
Public.

Description

Avoid problems where PW prompt in enter_chroot.sh would block other terminals. Change-Id: Ibd32a4be12e88d183dd0acbcb156582ad946c92f BUG=chromium-os:11602 TEST=Added a 'sudo -K' as the first line of teardown_env to simulate sudo timeout, then performed steps in bug report (without 15 minute wait). Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=a8d9cc1

Patch Set 1 #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -0 lines)			Patch
	M	enter_chroot.sh	View		2 chunks	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

diandersAtChromium

9 years, 10 months ago (2011-02-02 21:50:53 UTC) #1

Anush: PTAL.  I think this will address the problem that Puneet was seeing.  If
you see a more elegant solution, I'm certainly open to feedback!  :)

...also: do you have any suggestions for other reviewers?


Any driveby reviewers: feedback welcome!  Please see crosbug.com/11602 for
details.

Expand Messages | Collapse Messages