Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(718)

Issue 6250073: Add code to FakeReposBase to revert changes committed by a unit tests. (Closed)

Created:
9 years, 10 months ago by M-A Ruel
Modified:
9 years, 7 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, Peter Mayo
Visibility:
Public.

Description

Add code to FakeReposBase to revert changes committed by a unit tests. This enables seamless unit tests that check-in files without side-effects on the remaining unit tests. BUG=none TEST=none TBR=dpranke Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=73456

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -15 lines) Patch
M tests/fake_repos.py View 6 chunks +49 lines, -15 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
M-A Ruel
9 years, 10 months ago (2011-02-01 02:37:28 UTC) #1
Dirk Pranke
What's the point of the SHOULD_LEAK option?
9 years, 10 months ago (2011-02-01 05:18:34 UTC) #2
M-A Ruel
On 2011/02/01 05:18:34, dpranke wrote: > What's the point of the SHOULD_LEAK option? From line ...
9 years, 10 months ago (2011-02-01 14:38:13 UTC) #3
M-A Ruel
9 years, 10 months ago (2011-02-02 15:44:20 UTC) #4
Also TBR'ing this one since the new unit tests in the commit queue depends on
it.

Powered by Google App Engine
This is Rietveld 408576698