Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(797)

Issue 6250054: Temporary disable comparison of optimizability of code objects in some cases. (Closed)

Created:
9 years, 10 months ago by antonm
Modified:
9 years, 4 months ago
CC:
v8-dev
Visibility:
Public.

Description

Temporary disable comparison of optimizability of code objects in some cases. With crankshaft, a code object can change its optimizability: it can start as optimizable code object, but later we can find out it was a bad idea to optimize it. Alas, currently we don't have a proper event to communicate this back to logger. Hence we temporary allow a code object to be viewed as optimizable judging from logs while being unoptimizable judging from heap traversal. Committed: http://code.google.com/p/v8/source/detail?r=6553

Patch Set 1 #

Patch Set 2 : Fixed wording #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -5 lines) Patch
M test/cctest/cctest.status View 1 chunk +0 lines, -5 lines 0 comments Download
M test/cctest/test-log.cc View 1 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
antonm
Misha, small review for you. If it's lgty, I'll file a bug.
9 years, 10 months ago (2011-01-31 19:00:43 UTC) #1
mnaganov (inactive)
LGTM. I suppose, the transition between optimizable and unoptimizable code states is unidirectional?
9 years, 10 months ago (2011-02-01 09:10:42 UTC) #2
antonm
9 years, 10 months ago (2011-02-01 12:38:38 UTC) #3
Thanks a lot for review, Mikhail.

On 2011/02/01 09:10:42, Mikhail Naganov (Chromium) wrote:
> LGTM.
> 
> I suppose, the transition between optimizable and unoptimizable code states is
> unidirectional?

As far as I know yes.

Powered by Google App Engine
This is Rietveld 408576698