Issue 6250028: Mark BrowserActionApiTest.BrowserActionPopup flaky.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6250028: Mark BrowserActionApiTest.BrowserActionPopup flaky. (Closed)

Created:
9 years, 11 months ago by lzheng

Modified:
9 years, 7 months ago

Reviewers:
TVL, lzheng1

CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, pam+watch_chromium.org, Paweł Hajdan Jr., kkania

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Mark BrowserActionApiTest.BrowserActionPopup flaky. TEST=none BUG=70829 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72552

Patch Set 1 #

Patch Set 2 : '' #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -1 line)			Patch
	M	chrome/browser/extensions/browser_action_apitest.cc	View	1	1 chunk	+8 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

lzheng

This is a flaky test, it sometimes timeout on Vista and linux.

9 years, 11 months ago (2011-01-25 21:21:55 UTC) #1

TVL

lg if it's only flaky on some platforms should it use the MAYBE_ pattern?

9 years, 11 months ago (2011-01-25 21:29:19 UTC) #2

lzheng1

9 years, 11 months ago (2011-01-25 21:46:39 UTC) #3

Okay. I updated the change so we don't mark mac flaky.

Commited.

On Tue, Jan 25, 2011 at 1:29 PM, <thomasvl@chromium.org> wrote:

> lg
>
> if it's only flaky on some platforms should it use the MAYBE_ pattern?
>
>
> http://codereview.chromium.org/6250028/
>

Expand Messages | Collapse Messages