Port lithium template classes to ARM....

Port lithium template classes to ARM.

This is a port of the IA32 version and is needed to allow 
changing the register allocator interface in a later change.




Committed: http://code.google.com/p/v8/source/detail?r=6436

[Søren Thygesen Gjesse, 2011-01-24 08:08:40]

LGTM

http://codereview.chromium.org/6250027/diff/7001/src/arm/lithium-arm.cc
File src/arm/lithium-arm.cc (right):

http://codereview.chromium.org/6250027/diff/7001/src/arm/lithium-arm.cc#newco...
src/arm/lithium-arm.cc:901: // TODO(fschneider): Handle test instructions
uniformly like
Username -> issue number

http://codereview.chromium.org/6250027/diff/7001/src/arm/lithium-arm.h
File src/arm/lithium-arm.h (right):

http://codereview.chromium.org/6250027/diff/7001/src/arm/lithium-arm.h#newcod...
src/arm/lithium-arm.h:336: template<typename T, int N>
I know that templates are usually specified using single uppercase letters, but
it is sometimes quite difficult to guess what they specify (here T is a type in
one place and the temporary count in another place). A short comment on what
each argument specify would be nice. And maybe use names - a least for the
non-type arguments.

http://codereview.chromium.org/6250027/diff/7001/src/arm/lithium-arm.h#newcod...
src/arm/lithium-arm.h:531: 
Any particular reason for not keeping the LBinaryOperation?

template<int T>
class LBinaryOperation: public LTemplateInstruction<1, 2, T> {
  ...

[fschneider, 2011-01-24 09:40:16]

http://codereview.chromium.org/6250027/diff/7001/src/arm/lithium-arm.cc
File src/arm/lithium-arm.cc (right):

http://codereview.chromium.org/6250027/diff/7001/src/arm/lithium-arm.cc#newco...
src/arm/lithium-arm.cc:901: // TODO(fschneider): Handle test instructions
uniformly like
On 2011/01/24 08:08:40, Søren Gjesse wrote:
> Username -> issue number

I removed the todo since it really is part of our bigger refactoring of the IR.

http://codereview.chromium.org/6250027/diff/7001/src/arm/lithium-arm.h
File src/arm/lithium-arm.h (right):

http://codereview.chromium.org/6250027/diff/7001/src/arm/lithium-arm.h#newcod...
src/arm/lithium-arm.h:336: template<typename T, int N>
On 2011/01/24 08:08:40, Søren Gjesse wrote:
> I know that templates are usually specified using single uppercase letters,
but
> it is sometimes quite difficult to guess what they specify (here T is a type
in
> one place and the temporary count in another place). A short comment on what
> each argument specify would be nice. And maybe use names - a least for the
> non-type arguments.

Done.

http://codereview.chromium.org/6250027/diff/7001/src/arm/lithium-arm.h#newcod...
src/arm/lithium-arm.h:531: 
On 2011/01/24 08:08:40, Søren Gjesse wrote:
> Any particular reason for not keeping the LBinaryOperation?
> 
> template<int T>
> class LBinaryOperation: public LTemplateInstruction<1, 2, T> {
>   ...

I preferred always having all three template parameters explicitly.
LBinaryOperation would be really just a typedef abbreviation for
LTemplateInstruction<1, 2, T>.