Issue 6250024: Add a target for the proxy unittests. Write tests for the var tracker....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6250024: Add a target for the proxy unittests. Write tests for the var tracker.... (Closed)

Created:
9 years, 11 months ago by brettw

Modified:
9 years, 7 months ago

Reviewers:
David Springer, piman

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Add a target for the proxy unittests. Write tests for the var tracker. TEST=this is it BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72158

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 2

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+206 lines, -0 lines)			Patch
M	ppapi/ppapi.gyp	View	1	1 chunk	+20 lines, -0 lines	0 comments	Download
M	ppapi/proxy/plugin_var_tracker.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
A	ppapi/proxy/plugin_var_tracker_unittest.cc	View	1	1 chunk	+176 lines, -0 lines	1 comment	Download
A	ppapi/proxy/run_all_unittests.cc	View	1	1 chunk	+9 lines, -0 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

piman

9 years, 11 months ago (2011-01-21 17:11:56 UTC) #3

LGTM

http://codereview.chromium.org/6250024/diff/12001/ppapi/proxy/plugin_var_trac...
File ppapi/proxy/plugin_var_tracker_unittest.cc (right):

http://codereview.chromium.org/6250024/diff/12001/ppapi/proxy/plugin_var_trac...
ppapi/proxy/plugin_var_tracker_unittest.cc:48: PP_Var
MakeString(PluginVarTracker::VarID string_id) {
Move this to anonymous namespace ?

http://codereview.chromium.org/6250024/diff/12001/ppapi/proxy/run_all_unittes...
File ppapi/proxy/run_all_unittests.cc (right):

http://codereview.chromium.org/6250024/diff/12001/ppapi/proxy/run_all_unittes...
ppapi/proxy/run_all_unittests.cc:1: // Copyright (c) 2009 The Chromium Authors.
All rights reserved.
2011

Expand Messages | Collapse Messages