Issue 6250015: Speculative fix for a bug that happens during Chrome Frame teardown while the...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6250015: Speculative fix for a bug that happens during Chrome Frame teardown while the... (Closed)

Created:
9 years, 11 months ago by robertshield

Modified:
9 years, 6 months ago

Reviewers:
ananta

CC:
chromium-reviews, amit, tommi (sloooow) - chröme

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Speculative fix for a bug that happens during Chrome Frame teardown while there are pending IPC messages to be handled. Keep the ChromeFrameAutomationProxyImpl instance alive until all messages have been handled. BUG=68869 TEST=No more crashes during handling of OnChannelError during teardown. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71951

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -3 lines)			Patch
	M	chrome_frame/chrome_frame_automation.cc	View		1 chunk	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM++

Expand Messages | Collapse Messages