Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(531)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 6250014: Move more dnd related files to ui/base (Closed)

Created:
9 years, 11 months ago by Ben Goodger (Google)
Modified:
9 years, 6 months ago
Reviewers:
brettw
CC:
chromium-reviews, Erik does not do reviews, brettw-cc_chromium.org, Aaron Boodman, darin-cc_chromium.org, rdsmith+dwatch_chromium.org, Paweł Hajdan Jr., pam+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Move more dnd related files to ui/base BUG=none TEST=none TBR=brettw Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71828

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+328 lines, -1324 lines) Patch
M app/app.gyp View 1 chunk +1 line, -1 line 0 comments Download
M app/app_base.gypi View 6 chunks +11 lines, -11 lines 0 comments Download
D app/download_file_interface.h View 1 chunk +0 lines, -47 lines 0 comments Download
D app/drag_drop_types.h View 1 chunk +0 lines, -31 lines 0 comments Download
D app/drag_drop_types_gtk.cc View 1 chunk +0 lines, -31 lines 0 comments Download
D app/drag_drop_types_win.cc View 1 chunk +0 lines, -30 lines 0 comments Download
D app/gtk_dnd_util.h View 1 chunk +0 lines, -88 lines 0 comments Download
D app/gtk_dnd_util.cc View 1 chunk +0 lines, -263 lines 0 comments Download
D app/gtk_dnd_util_unittest.cc View 1 chunk +0 lines, -77 lines 0 comments Download
D app/win/drag_source.h View 1 chunk +0 lines, -58 lines 0 comments Download
D app/win/drag_source.cc View 1 chunk +0 lines, -57 lines 0 comments Download
D app/win/drop_target.h View 1 chunk +0 lines, -136 lines 0 comments Download
D app/win/drop_target.cc View 1 chunk +0 lines, -174 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_edit_view_win.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_utils.cc View 6 chunks +21 lines, -21 lines 0 comments Download
M chrome/browser/chromeos/dom_ui/imageburner_ui.h View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/download/download_util.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/download/drag_download_file.h View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/download/drag_download_file.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/drag_download_util.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/tab_contents/web_drag_dest_gtk.cc View 11 chunks +17 lines, -23 lines 0 comments Download
M chrome/browser/tab_contents/web_drag_source_win.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/tab_contents/web_drag_source_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/web_drop_target_win.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/tab_contents/web_drop_target_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/bookmark_bar_gtk.cc View 11 chunks +17 lines, -19 lines 0 comments Download
M chrome/browser/ui/gtk/bookmark_menu_controller_gtk.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/gtk/bookmark_utils_gtk.cc View 11 chunks +13 lines, -13 lines 0 comments Download
M chrome/browser/ui/gtk/bookmark_utils_gtk_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/gtk/browser_toolbar_gtk.cc View 4 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/ui/gtk/custom_drag.cc View 5 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/ui/gtk/location_bar_view_gtk.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/gtk/tab_contents_drag_source.cc View 9 chunks +26 lines, -32 lines 0 comments Download
M chrome/browser/ui/gtk/tabs/tab_gtk.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/gtk/tabs/tab_strip_gtk.cc View 4 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/ui/views/bookmark_bar_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/bookmark_bar_view.cc View 6 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/ui/views/browser_actions_container.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_root_view.cc View 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_strip.cc View 5 chunks +8 lines, -8 lines 0 comments Download
A + ui/base/dragdrop/download_file_interface.h View 3 chunks +8 lines, -4 lines 0 comments Download
A + ui/base/dragdrop/drag_drop_types.h View 2 chunks +8 lines, -4 lines 0 comments Download
A + ui/base/dragdrop/drag_drop_types_gtk.cc View 3 chunks +8 lines, -4 lines 0 comments Download
A + ui/base/dragdrop/drag_drop_types_win.cc View 3 chunks +8 lines, -4 lines 0 comments Download
A + ui/base/dragdrop/drag_source.h View 3 chunks +6 lines, -8 lines 0 comments Download
A + ui/base/dragdrop/drag_source.cc View 2 chunks +4 lines, -6 lines 0 comments Download
A + ui/base/dragdrop/drop_target.h View 3 chunks +6 lines, -8 lines 0 comments Download
A + ui/base/dragdrop/drop_target.cc View 2 chunks +4 lines, -6 lines 0 comments Download
A + ui/base/dragdrop/gtk_dnd_util.h View 3 chunks +6 lines, -6 lines 0 comments Download
A + ui/base/dragdrop/gtk_dnd_util.cc View 4 chunks +5 lines, -5 lines 0 comments Download
A + ui/base/dragdrop/gtk_dnd_util_unittest.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M ui/base/dragdrop/os_exchange_data.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/dragdrop/os_exchange_data_provider_gtk.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M views/controls/button/menu_button.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M views/controls/menu/menu_controller.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M views/controls/menu/menu_delegate.h View 2 chunks +5 lines, -5 lines 0 comments Download
M views/controls/menu/menu_scroll_view_container.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M views/event.h View 1 chunk +1 line, -1 line 0 comments Download
M views/view.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M views/view_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M views/widget/drop_helper.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M views/widget/drop_target_gtk.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M views/widget/drop_target_win.h View 2 chunks +2 lines, -2 lines 0 comments Download
M views/widget/drop_target_win.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M views/widget/root_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M views/widget/root_view_win.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M views/widget/widget_gtk.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/tools/test_shell/drag_delegate.h View 1 chunk +5 lines, -5 lines 0 comments Download
M webkit/tools/test_shell/drop_delegate.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Ben Goodger (Google)
9 years, 11 months ago (2011-01-19 17:49:25 UTC) #1
brettw
9 years, 11 months ago (2011-01-19 18:12:15 UTC) #2 
Rubber stamp LGTM

Powered by Google App Engine
This is Rietveld 408576698