Make the gtk download shelf autoclose on mouse out.

gfx/insets.h

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef GFX_INSETS_H_
 #define GFX_INSETS_H_
 #pragma once
 
 #include "build/build_config.h"
 
@@ skipping 11 matching lines @@
 //
 
 class Insets {
  public:
   Insets() : top_(0), left_(0), bottom_(0), right_(0) {}
   Insets(int top, int left, int bottom, int right)
       : top_(top),
         left_(left),
         bottom_(bottom),
         right_(right) {}
+  Insets(int top_bottom, int left_right)

[sky, 2011/01/31 17:14:04]

Are you even using the two constructors you're adding?

[Evan Stade, 2011/01/31 18:59:49]

well I did at first, but then I changed my mind. I fashioned this change after
the way defining borders works in css. I can remove the change if you want, but
it seems like a common use case.

[sky, 2011/01/31 20:36:25]

Given that no one is using them, I say nuke them. I don't so much mind the
single arg one, but the two arg one is mildly confusing.

+      : top_(top_bottom),
+        left_(left_right),
+        bottom_(top_bottom),
+        right_(left_right) {}
+  Insets(int inset)

[sky, 2011/01/31 17:14:04]

explicit

[Evan Stade, 2011/01/31 18:59:49]

Done.

+      : top_(inset),
+        left_(inset),
+        bottom_(inset),
+        right_(inset) {}
 #if defined(OS_POSIX) && !defined(OS_MACOSX)
   explicit Insets(const GtkBorder& border)
       : top_(border.top),
         left_(border.left),
         bottom_(border.bottom),
         right_(border.right) {}
 #endif
 
   ~Insets() {}
 
@@ skipping 43 matching lines @@
  private:
   int top_;
   int left_;
   int bottom_;
   int right_;
 };
 
 }  // namespace gfx
 
 #endif  // GFX_INSETS_H_