Issue 6249013: Return 0 instead of AVERROR_EOF for reads at or past the end of a file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6249013: Return 0 instead of AVERROR_EOF for reads at or past the end of a file. (Closed)

Created:
9 years, 11 months ago by scherkus (not reviewing)

Modified:
9 years, 7 months ago

Reviewers:
acolwell GONE FROM CHROMIUM

CC:
chromium-reviews, vrk (LEFT CHROMIUM), sjl, Alpha Left Google, ddorwin+watch_chromium.org, acolwell GONE FROM CHROMIUM, annacc, awong, Paweł Hajdan Jr., scherkus (not reviewing)

Base URL:
svn://chrome-svn/chrome/trunk/src

Visibility:
Public.

Description

Return 0 instead of AVERROR_EOF for reads at or past the end of a file. I'm not sure if it's because the files listed in the bug report were improperly muxed, but FFmpeg was attempting to read past the end of the file and apparently returning AVERROR_EOF instead of 0 makes a huge difference. BUG=47489 TEST=media_unittests, files linked in bug report Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72350

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -5 lines)			Patch
	M	media/filters/ffmpeg_demuxer.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download
	M	media/filters/ffmpeg_demuxer_unittest.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages