Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Unified Diff: chrome/browser/translate/translate_manager.cc

Issue 6249010: Cleanup: de-inline a bunch of classes, rename and move "PluginInstaller" to "... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/translate/translate_manager.cc
===================================================================
--- chrome/browser/translate/translate_manager.cc (revision 72158)
+++ chrome/browser/translate/translate_manager.cc (working copy)
@@ -415,8 +415,7 @@
// Prompts the user if he/she wants the page translated.
tab->AddInfoBar(TranslateInfoBarDelegate::CreateDelegate(
- TranslateInfoBarDelegate::BEFORE_TRANSLATE, tab,
- page_lang, target_lang));
+ TranslateInfoBarDelegate::BEFORE_TRANSLATE, tab, page_lang, target_lang));
}
void TranslateManager::InitiateTranslationPosted(
@@ -529,9 +528,8 @@
// Create the new infobar to display.
TranslateInfoBarDelegate* infobar;
if (details->error_type != TranslateErrors::NONE) {
- infobar = TranslateInfoBarDelegate::CreateErrorDelegate(
- details->error_type, tab,
- details->source_language, details->target_language);
+ infobar = TranslateInfoBarDelegate::CreateErrorDelegate(details->error_type,
+ tab, details->source_language, details->target_language);
} else if (!IsSupportedLanguage(details->source_language)) {
// TODO(jcivelli): http://crbug.com/9390 We should change the "after
// translate" infobar to support unknown as the original
@@ -627,9 +625,7 @@
std::string TranslateManager::GetTargetLanguage() {
std::string target_lang =
GetLanguageCode(g_browser_process->GetApplicationLocale());
- if (IsSupportedLanguage(target_lang))
- return target_lang;
- return std::string();
+ return IsSupportedLanguage(target_lang) ? target_lang : std::string();
}
// static
« no previous file with comments | « chrome/browser/translate/translate_infobar_delegate.cc ('k') | chrome/browser/translate/translate_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698