Cleanup of r71320 commit.

Cleanup of r71320 commit.

For ChromeOS: when starting session: if locale was changed (as a result of sync or because user preference differs from login locale): show notification. 

BUG=chromium-os:9164
TEST=Manual

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71646

[Denis Lagno, 2011-01-17 14:39:45]

please take a look

[brettw, 2011-01-17 16:40:30]

LGTM, thanks!

http://codereview.chromium.org/6249009/diff/5001/chrome/browser/chromeos/loca...
File chrome/browser/chromeos/locale_change_guard.cc (right):

http://codereview.chromium.org/6249009/diff/5001/chrome/browser/chromeos/loca...
chrome/browser/chromeos/locale_change_guard.cc:37: || tab_contents_ == NULL
In Chrome we'll normally put the || at the end of the previous line.

http://codereview.chromium.org/6249009/diff/5001/chrome/browser/chromeos/loca...
chrome/browser/chromeos/locale_change_guard.cc:103: DCHECK(note_ == NULL &&
tab_contents_ == NULL);
You already did these two DCHECKs at the top of the function, and I don't think
either of them can change. I'd just delete them if this is the case.

http://codereview.chromium.org/6249009/diff/5001/chrome/browser/chromeos/loca...
chrome/browser/chromeos/locale_change_guard.cc:106: if (!from_locale.empty() &&
from_locale != to_locale) {
I actually liked the old way of returning early in this case. The reason is that
you return early a bunch above, and somehow it's easier for me to follow if a
function is either consistently return early or not.

http://codereview.chromium.org/6249009/diff/5001/chrome/browser/chromeos/loca...
chrome/browser/chromeos/locale_change_guard.cc:131: || tab_contents_ == NULL
Ditto with || at the end.

[Denis Lagno, 2011-01-17 17:44:13]

http://codereview.chromium.org/6249009/diff/5001/chrome/browser/chromeos/loca...
File chrome/browser/chromeos/locale_change_guard.cc (right):

http://codereview.chromium.org/6249009/diff/5001/chrome/browser/chromeos/loca...
chrome/browser/chromeos/locale_change_guard.cc:37: || tab_contents_ == NULL
On 2011/01/17 16:40:30, brettw wrote:
> In Chrome we'll normally put the || at the end of the previous line.

Done.

http://codereview.chromium.org/6249009/diff/5001/chrome/browser/chromeos/loca...
chrome/browser/chromeos/locale_change_guard.cc:103: DCHECK(note_ == NULL &&
tab_contents_ == NULL);
On 2011/01/17 16:40:30, brettw wrote:
> You already did these two DCHECKs at the top of the function, and I don't
think
> either of them can change. I'd just delete them if this is the case.

Done.

http://codereview.chromium.org/6249009/diff/5001/chrome/browser/chromeos/loca...
chrome/browser/chromeos/locale_change_guard.cc:106: if (!from_locale.empty() &&
from_locale != to_locale) {
On 2011/01/17 16:40:30, brettw wrote:
> I actually liked the old way of returning early in this case. The reason is
that
> you return early a bunch above, and somehow it's easier for me to follow if a
> function is either consistently return early or not.

Done.

http://codereview.chromium.org/6249009/diff/5001/chrome/browser/chromeos/loca...
chrome/browser/chromeos/locale_change_guard.cc:131: || tab_contents_ == NULL
On 2011/01/17 16:40:30, brettw wrote:
> Ditto with || at the end.

Done.