Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2890)

Unified Diff: base/i18n/bidi_line_iterator.h

Issue 6249007: Move BiDiLineIterator to base/i18n/ directory. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: remove unncessary includes Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/base.gyp ('k') | base/i18n/bidi_line_iterator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/i18n/bidi_line_iterator.h
diff --git a/app/bidi_line_iterator.h b/base/i18n/bidi_line_iterator.h
similarity index 74%
rename from app/bidi_line_iterator.h
rename to base/i18n/bidi_line_iterator.h
index a4faa2f8dbee08a224c41ff241e45f1e883eb7e4..5fff6a363738e5985e7e974c06be53aa93e1ac95 100644
--- a/app/bidi_line_iterator.h
+++ b/base/i18n/bidi_line_iterator.h
@@ -1,29 +1,30 @@
-// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef APP_BIDI_LINE_ITERATOR_H_
-#define APP_BIDI_LINE_ITERATOR_H_
+#ifndef BASE_I18N_BIDI_LINE_ITERATOR_H_
+#define BASE_I18N_BIDI_LINE_ITERATOR_H_
#pragma once
-#include <string>
-
#include "unicode/ubidi.h"
#include "base/basictypes.h"
#include "base/string16.h"
+namespace base {
+namespace i18n {
+
// A simple wrapper class for the bidirectional iterator of ICU.
// This class uses the bidirectional iterator of ICU to split a line of
// bidirectional texts into visual runs in its display order.
class BiDiLineIterator {
public:
- BiDiLineIterator() : bidi_(NULL) { }
+ BiDiLineIterator();
~BiDiLineIterator();
// Initializes the bidirectional iterator with the specified text. Returns
// whether initialization succeeded.
- UBool Open(const string16& text, bool right_to_left, bool url);
+ bool Open(const string16& text, bool right_to_left, bool url);
// Returns the number of visual runs in the text, or zero on error.
int CountRuns();
@@ -40,4 +41,7 @@ class BiDiLineIterator {
DISALLOW_COPY_AND_ASSIGN(BiDiLineIterator);
};
-#endif // APP_BIDI_LINE_ITERATOR_H_
+} // namespace i18n
+} // namespace base
+
+#endif // BASE_I18N_BIDI_LINE_ITERATOR_H_
« no previous file with comments | « base/base.gyp ('k') | base/i18n/bidi_line_iterator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698