Move BiDiLineIterator to base/i18n/ directory.

base/i18n/bidi_line_iterator.cc

-// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#include "app/bidi_line_iterator.h"
+#include "base/i18n/bidi_line_iterator.h"
 
 #include "base/logging.h"
 #include "base/string16.h"
 #include "base/utf_string_conversions.h"
 
 BiDiLineIterator::~BiDiLineIterator() {
   if (bidi_) {
     ubidi_close(bidi_);
     bidi_ = NULL;
   }
 }
 
 UBool BiDiLineIterator::Open(const std::wstring& text,

[brettw, 2011/01/14 19:09:51]

Can we replace wstring with string16? Then you can remove the WCHAR_T_IS_UTF32
ifdef below.

Also, can we use bool instead of UBool as the return value here?

[tfarina, 2011/01/14 23:16:10]

Done.

                              bool right_to_left,
                              bool url) {
   DCHECK(bidi_ == NULL);
   UErrorCode error = U_ZERO_ERROR;
   bidi_ = ubidi_openSized(static_cast<int>(text.length()), 0, &error);
   if (U_FAILURE(error))
     return false;
   if (right_to_left && url)
     ubidi_setReorderingMode(bidi_, UBIDI_REORDER_RUNS_ONLY);
 #if defined(WCHAR_T_IS_UTF32)
@@ skipping 20 matching lines @@
   DCHECK(bidi_ != NULL);
   return ubidi_getVisualRun(bidi_, index, start, length);
 }
 
 void BiDiLineIterator::GetLogicalRun(int start,
                                      int* end,
                                      UBiDiLevel* level) {
   DCHECK(bidi_ != NULL);
   ubidi_getLogicalRun(bidi_, start, end, level);
 }