Move BiDiLineIterator to base/i18n/ directory.

base/i18n/bidi_line_iterator.h

-// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifndef APP_BIDI_LINE_ITERATOR_H_
-#define APP_BIDI_LINE_ITERATOR_H_
+#ifndef BASE_I18N_BIDI_LINE_ITERATOR_H_
+#define BASE_I18N_BIDI_LINE_ITERATOR_H_
 #pragma once
 
 #include <string>
 
 #include "unicode/ubidi.h"

[tony, 2011/01/18 19:24:29]

What happened when you tried to move this include into the .cc file?

[tfarina, 2011/01/18 19:34:47]

As I told to Brett:
"It's possible to forward this struct and UBiDiLevel (an uint8_t), but it isn't
possible to forward the enum UBiDiDirection."

I have the error saved somewhere, but I don't have it right now.

 
 #include "base/basictypes.h"
 #include "base/string16.h"
 
+namespace base {
+namespace i18n {
+
 // A simple wrapper class for the bidirectional iterator of ICU.
 // This class uses the bidirectional iterator of ICU to split a line of
 // bidirectional texts into visual runs in its display order.
 class BiDiLineIterator {
  public:
-  BiDiLineIterator() : bidi_(NULL) { }
+  BiDiLineIterator();
   ~BiDiLineIterator();
 
   // Initializes the bidirectional iterator with the specified text.  Returns
   // whether initialization succeeded.
-  UBool Open(const string16& text, bool right_to_left, bool url);
+  bool Open(const string16& text, bool right_to_left, bool url);
 
   // Returns the number of visual runs in the text, or zero on error.
   int CountRuns();
 
   // Gets the logical offset, length, and direction of the specified visual run.
   UBiDiDirection GetVisualRun(int index, int* start, int* length);
 
   // Given a start position, figure out where the run ends (and the BiDiLevel).
   void GetLogicalRun(int start, int* end, UBiDiLevel* level);
 
  private:
   UBiDi* bidi_;
 
   DISALLOW_COPY_AND_ASSIGN(BiDiLineIterator);
 };
 
-#endif  // APP_BIDI_LINE_ITERATOR_H_
+}  // namespace i18n
+}  // namespace base
+
+#endif  // BASE_I18N_BIDI_LINE_ITERATOR_H_