Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1631)

Unified Diff: ceee/ie/plugin/bho/webnavigation_events_funnel_unittest.cc

Issue 6248026: Rename Real* to Double* in values.* and dependent files (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: More renames Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ceee/ie/plugin/bho/webnavigation_events_funnel_unittest.cc
diff --git a/ceee/ie/plugin/bho/webnavigation_events_funnel_unittest.cc b/ceee/ie/plugin/bho/webnavigation_events_funnel_unittest.cc
index 87d307a42c335d0c12a3f61af63a31046d634d11..351c58c71c5501558c502dba6fc16020c7d4ec45 100644
--- a/ceee/ie/plugin/bho/webnavigation_events_funnel_unittest.cc
+++ b/ceee/ie/plugin/bho/webnavigation_events_funnel_unittest.cc
@@ -45,8 +45,8 @@ TEST(WebNavigationEventsFunnelTest, OnBeforeNavigate) {
args.SetString(keys::kUrlKey, url);
args.SetInteger(keys::kFrameIdKey, frame_id);
args.SetInteger(keys::kRequestIdKey, request_id);
- args.SetReal(keys::kTimeStampKey,
- base::Time::kMillisecondsPerSecond * time_stamp.ToDoubleT());
+ args.SetDouble(keys::kTimeStampKey,
+ base::Time::kMillisecondsPerSecond * time_stamp.ToDoubleT());
EXPECT_CALL(webnavigation_events_funnel,
SendEvent(StrEq(keys::kOnBeforeNavigate), ValuesEqual(&args)))
@@ -68,8 +68,8 @@ TEST(WebNavigationEventsFunnelTest, OnBeforeRetarget) {
args.SetInteger(keys::kSourceTabIdKey, source_tab_handle);
args.SetString(keys::kSourceUrlKey, source_url);
args.SetString(keys::kTargetUrlKey, target_url);
- args.SetReal(keys::kTimeStampKey,
- base::Time::kMillisecondsPerSecond * time_stamp.ToDoubleT());
+ args.SetDouble(keys::kTimeStampKey,
+ base::Time::kMillisecondsPerSecond * time_stamp.ToDoubleT());
EXPECT_CALL(webnavigation_events_funnel,
SendEvent(StrEq(keys::kOnBeforeRetarget), ValuesEqual(&args)))
@@ -95,8 +95,8 @@ TEST(WebNavigationEventsFunnelTest, OnCommitted) {
args.SetInteger(keys::kFrameIdKey, frame_id);
args.SetString(keys::kTransitionTypeKey, transition_type);
args.SetString(keys::kTransitionQualifiersKey, transition_qualifiers);
- args.SetReal(keys::kTimeStampKey,
- base::Time::kMillisecondsPerSecond * time_stamp.ToDoubleT());
+ args.SetDouble(keys::kTimeStampKey,
+ base::Time::kMillisecondsPerSecond * time_stamp.ToDoubleT());
EXPECT_CALL(webnavigation_events_funnel,
SendEvent(StrEq(keys::kOnCommitted), ValuesEqual(&args)))
@@ -119,8 +119,8 @@ TEST(WebNavigationEventsFunnelTest, OnCompleted) {
args.SetInteger(keys::kTabIdKey, tab_handle);
args.SetString(keys::kUrlKey, url);
args.SetInteger(keys::kFrameIdKey, frame_id);
- args.SetReal(keys::kTimeStampKey,
- base::Time::kMillisecondsPerSecond * time_stamp.ToDoubleT());
+ args.SetDouble(keys::kTimeStampKey,
+ base::Time::kMillisecondsPerSecond * time_stamp.ToDoubleT());
EXPECT_CALL(webnavigation_events_funnel,
SendEvent(StrEq(keys::kOnCompleted), ValuesEqual(&args)))
@@ -142,8 +142,8 @@ TEST(WebNavigationEventsFunnelTest, OnDOMContentLoaded) {
args.SetInteger(keys::kTabIdKey, tab_handle);
args.SetString(keys::kUrlKey, url);
args.SetInteger(keys::kFrameIdKey, frame_id);
- args.SetReal(keys::kTimeStampKey,
- base::Time::kMillisecondsPerSecond * time_stamp.ToDoubleT());
+ args.SetDouble(keys::kTimeStampKey,
+ base::Time::kMillisecondsPerSecond * time_stamp.ToDoubleT());
EXPECT_CALL(webnavigation_events_funnel,
SendEvent(StrEq(keys::kOnDOMContentLoaded), ValuesEqual(&args)))
@@ -167,8 +167,8 @@ TEST(WebNavigationEventsFunnelTest, OnErrorOccurred) {
args.SetString(keys::kUrlKey, url);
args.SetInteger(keys::kFrameIdKey, frame_id);
args.SetString(keys::kErrorKey, error);
- args.SetReal(keys::kTimeStampKey,
- base::Time::kMillisecondsPerSecond * time_stamp.ToDoubleT());
+ args.SetDouble(keys::kTimeStampKey,
+ base::Time::kMillisecondsPerSecond * time_stamp.ToDoubleT());
EXPECT_CALL(webnavigation_events_funnel,
SendEvent(StrEq(keys::kOnErrorOccurred), ValuesEqual(&args)))

Powered by Google App Engine
This is Rietveld 408576698