Issue 6248019: Pass empty cros_user string to GetProfileSyncService() in sync integration tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6248019: Pass empty cros_user string to GetProfileSyncService() in sync integration tests (Closed)

Created:
9 years, 11 months ago by Raghu Simha

Modified:
9 years, 7 months ago

Reviewers:
tim (not reviewing)

CC:
chromium-reviews, Raghu Simha, ncarter (slow), tim (not reviewing), idana, DaleCurtis, stevenjb

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Pass empty cros_user string to GetProfileSyncService() in sync integration tests The sync integration tests are broken on chrome OS because a cros_string is not being passed to GetProfileSyncService() in ProfileSyncServiceHarness::SetupSync(), causing no ProfileSyncService object to be returned. This patch passes an empty cros_user string to GetProfileSyncService(), thereby fixing the sync integration tests on chrome OS. BUG=70854, chromium-os:11319, chromium-os:9262 TEST=sync_integration_tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72574

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/browser/sync/profile_sync_service_harness.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

+stevenjb fyi

LGTM

Expand Messages | Collapse Messages