Do not use local override for language settings: always sync.

chrome/browser/profiles/profile_impl.cc

Index: chrome/browser/profiles/profile_impl.cc
diff --git a/chrome/browser/profiles/profile_impl.cc b/chrome/browser/profiles/profile_impl.cc
index e0d342941cbdf49c93f320fd970f1d3610e040e9..f247c86ca5a00628e33abe857df1c2bea52fb2b0 100644
--- a/chrome/browser/profiles/profile_impl.cc
+++ b/chrome/browser/profiles/profile_impl.cc
@@ -1366,18 +1366,12 @@ PromoCounter* ProfileImpl::GetInstantPromoCounter() {
 }
 
 #if defined(OS_CHROMEOS)
-void ProfileImpl::ChangeApplicationLocale(
-    const std::string& locale, bool keep_local) {
+void ProfileImpl::ChangeApplicationLocale(const std::string& locale) {
   if (locale.empty()) {
     NOTREACHED();
     return;
   }
-  if (keep_local) {
-    GetPrefs()->SetString(prefs::kApplicationLocaleOverride, locale);
-  } else {
-    GetPrefs()->SetString(prefs::kApplicationLocale, locale);
-    GetPrefs()->ClearPref(prefs::kApplicationLocaleOverride);
-  }
+  GetPrefs()->SetString(prefs::kApplicationLocale, locale);
   GetPrefs()->SetString(prefs::kApplicationLocaleBackup, locale);

[Nikita (slow), 2011/01/25 14:35:31]

Why kApplicationLocaleBackup / Accepted prefs state is different after local
change if compared with local change guard operations on these prefs.

[Denis Lagno, 2011/01/25 15:46:43]

Backup must not be cleared.  Backup should be kept as a reference.  In case
kApplicationLocale would change due to sync from other device then this Backup
value will allow us to show notification.
Added comment on that.

OTOH kApplicationLocaleAccepted can be cleared to make it clear that we allow
notifications again; or it can be just left equal to old value, I don't think it
matters.

   GetPrefs()->ClearPref(prefs::kApplicationLocaleAccepted);
   // We maintain kApplicationLocale property in both a global storage