Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(792)

Issue 6248015: DOMUI Prefs: Split search engines into two lists (Closed)

Created:
9 years, 11 months ago by stuartmorgan
Modified:
9 years, 7 months ago
Reviewers:
James Hawkins
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

DOMUI Prefs: Split search engines into two lists BUG=70332 TEST=Search engine list headers should match autofill options. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72224

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -245 lines) Patch
M chrome/browser/dom_ui/options/search_engine_manager_handler.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/dom_ui/options/search_engine_manager_handler.cc View 3 chunks +11 lines, -18 lines 0 comments Download
D chrome/browser/resources/options/list_inline_header_selection_controller.js View 1 chunk +0 lines, -96 lines 0 comments Download
M chrome/browser/resources/options/options.html View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/options/search_engine_manager.css View 1 chunk +18 lines, -50 lines 0 comments Download
M chrome/browser/resources/options/search_engine_manager.html View 1 chunk +6 lines, -1 line 0 comments Download
M chrome/browser/resources/options/search_engine_manager.js View 1 chunk +49 lines, -15 lines 0 comments Download
M chrome/browser/resources/options/search_engine_manager_engine_list.js View 6 chunks +36 lines, -62 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
stuartmorgan
9 years, 11 months ago (2011-01-21 22:46:35 UTC) #1
James Hawkins
9 years, 11 months ago (2011-01-21 22:53:56 UTC) #2
Love mass code removal. LGTM

Powered by Google App Engine
This is Rietveld 408576698