Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 6248014: Reapply change to with/arguments interaction. (Closed)

Created:
9 years, 11 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Reapply change to with/arguments interaction. This is svn r6415 with a bugfix. The bug was that we can have scopes with 0 heap slots (functions with such scopes do not need a local context) and scopes with at least Context::MIN_CONTEXT_SLOTS. The code generator only allocated a local context if there were strictly more than Context::MIN_CONTEXT_SLOTS. Before the change to with/arguments, it was impossible to actually get a function scope with exactly Context::MIN_CONTEXT_SLOTS because every such scope included a heap-allocated arguments (and arguments shadow) slot. Committed: http://code.google.com/p/v8/source/detail?r=6426

Patch Set 1 #

Patch Set 2 : Change test to be more consistent. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -39 lines) Patch
M src/arm/code-stubs-arm.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M src/arm/codegen-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/full-codegen-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/code-stubs.h View 1 chunk +7 lines, -6 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M src/ia32/codegen-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/scopes.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M src/x64/codegen-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/full-codegen-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/debug-evaluate-locals.js View 1 3 chunks +10 lines, -13 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Chromium)
The bugfix I adopted was to make the FastNewContextStub include the number of context slots ...
9 years, 11 months ago (2011-01-21 10:52:40 UTC) #1
Mads Ager (chromium)
9 years, 11 months ago (2011-01-21 11:02:56 UTC) #2
LGTM!

Powered by Google App Engine
This is Rietveld 408576698