Issue 6248011: IndexedDB: Update browser test after WebKit roll.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6248011: IndexedDB: Update browser test after WebKit roll. (Closed)

Created:
9 years, 11 months ago by hans

Modified:
9 years, 5 months ago

Reviewers:
jorlow

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

IndexedDB: Update browser test after WebKit roll. TEST=browser_tests --gtest_filter=IndexedDBBrowserTest.TransactionGetTest BUG=67323 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71950

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -5 lines)			Patch
	M	chrome/test/data/indexeddb/transaction_get_test.js	View		2 chunks	+4 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jorlow

9 years, 11 months ago (2011-01-20 10:42:10 UTC) #2

LGTM

On Thu, Jan 20, 2011 at 10:32 AM, <hans@chromium.org> wrote:

> Reviewers: jorlow,
>
> Description:
> IndexedDB: Update browser test after WebKit roll.
>
> TEST=browser_tests --gtest_filter=IndexedDBBrowserTest.TransactionGetTest
> BUG=67323
>
> Please review this at http://codereview.chromium.org/6248011/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>  M chrome/test/data/indexeddb/transaction_get_test.js
>
>
> Index: chrome/test/data/indexeddb/transaction_get_test.js
> diff --git a/chrome/test/data/indexeddb/transaction_get_test.js
> b/chrome/test/data/indexeddb/transaction_get_test.js
> index
>
0c5cfa8451927a127766bb20eda656cc77eee12b..74354785afa12a3d2aee234920dbb62d3b499910
> 100644
> --- a/chrome/test/data/indexeddb/transaction_get_test.js
> +++ b/chrome/test/data/indexeddb/transaction_get_test.js
> @@ -16,6 +16,7 @@ function afterCommit()
>
>  function nonExistingKey()
>  {
> +    shouldBe("event.result", "undefined");
>     window.setTimeout('afterCommit()', 0);
>  }
>
> @@ -36,11 +37,9 @@ function startTransaction()
>     result.onsuccess = gotValue;
>     result.onerror = unexpectedErrorCallback;
>
> -    // TODO(hans): Enable this again with the new semantics after WebKit
> rolls.
> -    //var emptyResult = store.get('nonExistingKey');
> -    //emptyResult.onsuccess = unexpectedSuccessCallback;
> -    //emptyResult.onerror = nonExistingKey;
> -    nonExistingKey();
> +    var emptyResult = store.get('nonExistingKey');
> +    emptyResult.onsuccess = nonExistingKey;
> +    emptyResult.onerror = unexpectedErrorCallback;
>  }
>
>  function populateObjectStore()
>
>
>

Expand Messages | Collapse Messages