Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Side by Side Diff: src/arm/frames-arm.h

Issue 6247019: Change ARM exit frame layout and alingment handling... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 89 matching lines...) Expand 10 before | Expand all | Expand 10 after
100 100
101 101
102 class EntryFrameConstants : public AllStatic { 102 class EntryFrameConstants : public AllStatic {
103 public: 103 public:
104 static const int kCallerFPOffset = -3 * kPointerSize; 104 static const int kCallerFPOffset = -3 * kPointerSize;
105 }; 105 };
106 106
107 107
108 class ExitFrameConstants : public AllStatic { 108 class ExitFrameConstants : public AllStatic {
109 public: 109 public:
110 static const int kCodeOffset = -1 * kPointerSize; 110 static const int kCodeOffset = -2 * kPointerSize;
111 static const int kSPOffset = -1 * kPointerSize; 111 static const int kSPOffset = -1 * kPointerSize;
112 112
113 // TODO(regis): Use a patched sp value on the stack instead.
114 // A marker of 0 indicates that double registers are saved.
115 static const int kMarkerOffset = -2 * kPointerSize;
116
117 // The caller fields are below the frame pointer on the stack. 113 // The caller fields are below the frame pointer on the stack.
118 static const int kCallerFPOffset = +0 * kPointerSize; 114 static const int kCallerFPOffset = +0 * kPointerSize;
119 // The calling JS function is between FP and PC. 115 // The calling JS function is below FP.
120 static const int kCallerPCOffset = +2 * kPointerSize; 116 static const int kCallerPCOffset = +1 * kPointerSize;
Mads Ager (chromium) 2011/01/24 18:21:08 Remove the +?
Søren Thygesen Gjesse 2011/01/25 07:48:39 Done.
121 117
122 // FP-relative displacement of the caller's SP. It points just 118 // FP-relative displacement of the caller's SP. It points just
123 // below the saved PC. 119 // below the saved PC.
124 static const int kCallerSPDisplacement = +3 * kPointerSize; 120 static const int kCallerSPDisplacement = +2 * kPointerSize;
Mads Ager (chromium) 2011/01/24 18:21:08 Remove the +?
Søren Thygesen Gjesse 2011/01/25 07:48:39 Done.
125 }; 121 };
126 122
127 123
128 class StandardFrameConstants : public AllStatic { 124 class StandardFrameConstants : public AllStatic {
129 public: 125 public:
130 static const int kExpressionsOffset = -3 * kPointerSize; 126 static const int kExpressionsOffset = -3 * kPointerSize;
131 static const int kMarkerOffset = -2 * kPointerSize; 127 static const int kMarkerOffset = -2 * kPointerSize;
132 static const int kContextOffset = -1 * kPointerSize; 128 static const int kContextOffset = -1 * kPointerSize;
133 static const int kCallerFPOffset = 0 * kPointerSize; 129 static const int kCallerFPOffset = 0 * kPointerSize;
134 static const int kCallerPCOffset = +1 * kPointerSize; 130 static const int kCallerPCOffset = +1 * kPointerSize;
(...skipping 28 matching lines...) Expand all
163 159
164 inline Object* JavaScriptFrame::function_slot_object() const { 160 inline Object* JavaScriptFrame::function_slot_object() const {
165 const int offset = JavaScriptFrameConstants::kFunctionOffset; 161 const int offset = JavaScriptFrameConstants::kFunctionOffset;
166 return Memory::Object_at(fp() + offset); 162 return Memory::Object_at(fp() + offset);
167 } 163 }
168 164
169 165
170 } } // namespace v8::internal 166 } } // namespace v8::internal
171 167
172 #endif // V8_ARM_FRAMES_ARM_H_ 168 #endif // V8_ARM_FRAMES_ARM_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698