Update ChromeOS theme engine to follow mocks in chromium-os:9256.

Update ChromeOS theme engine to follow mocks in chromium-os:9256.

BUG=chromium-os:9256
TEST=Verify web widgets (aka form controls) look close to the mock in chromium-os:9256.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71991

[DaveMoore, 2011-01-19 17:10:39]

http://codereview.chromium.org/6247012/diff/1/chrome/browser/chromeos/native_...
File chrome/browser/chromeos/native_theme_chromeos.cc (right):

http://codereview.chromium.org/6247012/diff/1/chrome/browser/chromeos/native_...
chrome/browser/chromeos/native_theme_chromeos.cc:32: const SkColor kGradient0 =
SkColorSetRGB(255, 255, 255);
Nit: Please use more descriptive names for these.

http://codereview.chromium.org/6247012/diff/1/chrome/browser/chromeos/native_...
chrome/browser/chromeos/native_theme_chromeos.cc:54: 
There are many inlined constants in this file. Could you please define named
constants for them? The designers frequently tweak them and it's going to be
hard to find them otherwise.

http://codereview.chromium.org/6247012/diff/1/chrome/browser/chromeos/native_...
chrome/browser/chromeos/native_theme_chromeos.cc:312: height = 16;
Use constants

[xiyuan, 2011-01-19 19:42:15]

CL updated to address comments.

I will rebase this one after the linux one
(http://codereview.chromium.org/6254004) gets in.

http://codereview.chromium.org/6247012/diff/1/chrome/browser/chromeos/native_...
File chrome/browser/chromeos/native_theme_chromeos.cc (right):

http://codereview.chromium.org/6247012/diff/1/chrome/browser/chromeos/native_...
chrome/browser/chromeos/native_theme_chromeos.cc:32: const SkColor kGradient0 =
SkColorSetRGB(255, 255, 255);
On 2011/01/19 17:10:39, davemoore wrote:
> Nit: Please use more descriptive names for these.

Done.

http://codereview.chromium.org/6247012/diff/1/chrome/browser/chromeos/native_...
chrome/browser/chromeos/native_theme_chromeos.cc:54: 
On 2011/01/19 17:10:39, davemoore wrote:
> There are many inlined constants in this file. Could you please define named
> constants for them? The designers frequently tweak them and it's going to be
> hard to find them otherwise.

Done.

http://codereview.chromium.org/6247012/diff/1/chrome/browser/chromeos/native_...
chrome/browser/chromeos/native_theme_chromeos.cc:312: height = 16;
On 2011/01/19 17:10:39, davemoore wrote:
> Use constants

Done.

[DaveMoore, 2011-01-19 22:25:48]

LGTM