Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Unified Diff: trychange.py

Issue 6247008: Add more logging. Useful to understand `git try` slowness. (Closed) Base URL: http://src.chromium.org/svn/trunk/tools/depot_tools/
Patch Set: Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gclient_utils.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trychange.py
===================================================================
--- trychange.py (revision 71600)
+++ trychange.py (working copy)
@@ -336,7 +336,9 @@
logging.info(options.diff)
try:
+ logging.info('Opening connection...')
connection = urllib.urlopen(url, urllib.urlencode(values), proxies=proxies)
+ logging.info('Done')
except IOError, e:
logging.info(str(e))
if (values.get('bot') and len(e.args) > 2 and
@@ -347,7 +349,9 @@
str(e.args)))
if not connection:
raise NoTryServerAccess('%s is unaccessible.' % url)
+ logging.info('Reading response...')
response = connection.read()
+ logging.info('Done')
if response != 'OK':
raise NoTryServerAccess('%s is unaccessible. Got:\n%s' % (url, response))
« no previous file with comments | « gclient_utils.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698