Issue 6247005: Add implementations of some more x64 lithium methods....

Issue 6247005: Add implementations of some more x64 lithium methods.... (Closed)

Created:
9 years, 11 months ago by Rico

Modified:
9 years, 6 months ago

Reviewers:
Kevin Millikin (Chromium), William Hesse

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Add implementations of some more x64 lithium methods. This puts us very close to being able to compile the empty function. This changes only has a small number of 64 bit specific assembler instructions. The remaining changes are much more platform specific and will go in another change. Committed: http://code.google.com/p/v8/source/detail?r=6306

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 3

Patch Set 4 : '' #

Total comments: 2

Patch Set 5 : '' #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+153 lines, -22 lines)			Patch
M	src/arm/lithium-arm.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	src/ia32/lithium-ia32.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	src/x64/assembler-x64.h	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View	1 2 3 4	5 chunks	+42 lines, -6 lines	0 comments	Download
M	src/x64/lithium-x64.cc	View	1 2 3	5 chunks	+108 lines, -12 lines	0 comments	Download
M	src/x64/macro-assembler-x64.cc	View	1 2 3	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

William Hesse

LGTM. http://codereview.chromium.org/6247005/diff/4002/src/x64/lithium-codegen-x64.cc File src/x64/lithium-codegen-x64.cc (right): http://codereview.chromium.org/6247005/diff/4002/src/x64/lithium-codegen-x64.cc#newcode503 src/x64/lithium-codegen-x64.cc:503: __ Move(ToRegister(instr->result()), instr->value()); Good, this handles smi constants ...

9 years, 11 months ago (2011-01-14 10:08:25 UTC) #2

Rico

http://codereview.chromium.org/6247005/diff/4002/src/x64/lithium-x64.cc File src/x64/lithium-x64.cc (right): http://codereview.chromium.org/6247005/diff/4002/src/x64/lithium-x64.cc#newcode1210 src/x64/lithium-x64.cc:1210: Abort("unsupported constant of type double"); On 2011/01/14 10:08:26, William ...

9 years, 11 months ago (2011-01-14 10:20:14 UTC) #3

Kevin Millikin (Chromium)

http://codereview.chromium.org/6247005/diff/20001/src/x64/lithium-codegen-x64.cc File src/x64/lithium-codegen-x64.cc (right): http://codereview.chromium.org/6247005/diff/20001/src/x64/lithium-codegen-x64.cc#newcode76 src/x64/lithium-codegen-x64.cc:76: char buffer[4 * KB]; Something looks wrong with the ...

9 years, 11 months ago (2011-01-14 10:22:43 UTC) #4

Rico

9 years, 11 months ago (2011-01-14 10:26:53 UTC) #5

http://codereview.chromium.org/6247005/diff/20001/src/x64/lithium-codegen-x64.cc
File src/x64/lithium-codegen-x64.cc (right):

http://codereview.chromium.org/6247005/diff/20001/src/x64/lithium-codegen-x64...
src/x64/lithium-codegen-x64.cc:76: char buffer[4 * KB];
On 2011/01/14 10:22:43, Kevin Millikin wrote:
> Something looks wrong with the indentation here.
> 
> I think this function body needs to be guarded by FLAG_code_comments?

Done.

Expand Messages | Collapse Messages