chromeos: Run beforeunload handlers when closing panels.

chromeos: Run beforeunload handlers when closing panels.

When a panel content window has a beforeunload handler, we'd
previously close its titlebar (which would cause the window
manager to also hide the content window in anticipation of
it being closed too), but then leave the content window
mapped and open a modal dialog (which would be kept
invisible by the window manager).  This would effectively
freeze the UI unless the user happened to press the Escape
key, which would still leave us in a state where we'd end up
restoring the panel again the next time the session was
restored.

This change makes us instead call BrowserView::CanClose()
first and avoid closing the panel if we're not supposed to.

BUG=chromium-os:10910
TEST=went to air1.com/listen and checked that i get an alert when closing the panel with "leave this page" and "stay on this page" buttons that function as expected

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71363

[DaveMoore, 2011-01-13 20:48:48]

LGTM

[oshima, 2011-01-13 21:18:11]

http://codereview.chromium.org/6247002/diff/1/chrome/browser/chromeos/frame/p...
File chrome/browser/chromeos/frame/panel_controller.cc (right):

http://codereview.chromium.org/6247002/diff/1/chrome/browser/chromeos/frame/p...
chrome/browser/chromeos/frame/panel_controller.cc:310: if
(!delegate_->CanClosePanel())
This may not be the scope of this CL, but wouldn't it be better to give visual
feedback that a user can't close the panel?

[Daniel Erat, 2011-01-13 21:26:34]

http://codereview.chromium.org/6247002/diff/1/chrome/browser/chromeos/frame/p...
File chrome/browser/chromeos/frame/panel_controller.cc (right):

http://codereview.chromium.org/6247002/diff/1/chrome/browser/chromeos/frame/p...
chrome/browser/chromeos/frame/panel_controller.cc:310: if
(!delegate_->CanClosePanel())
On 2011/01/13 21:18:12, oshima wrote:
> This may not be the scope of this CL, but wouldn't it be better to give visual
> feedback that a user can't close the panel?

In the case of a beforeunload handler, a modal dialog is opened.

[oshima, 2011-01-13 21:31:14]

On Thu, Jan 13, 2011 at 1:26 PM, <derat@chromium.org> wrote:

>
>
>
http://codereview.chromium.org/6247002/diff/1/chrome/browser/chromeos/frame/p...
> File chrome/browser/chromeos/frame/panel_controller.cc (right):
>
>
>
http://codereview.chromium.org/6247002/diff/1/chrome/browser/chromeos/frame/p...
> chrome/browser/chromeos/frame/panel_controller.cc:310: if
> (!delegate_->CanClosePanel())
> On 2011/01/13 21:18:12, oshima wrote:
>
>> This may not be the scope of this CL, but wouldn't it be better to
>>
> give visual
>
>> feedback that a user can't close the panel?
>>
>
> In the case of a beforeunload handler, a modal dialog is opened.


Got it .thank you for clarification.




>
> http://codereview.chromium.org/6247002/
>