|
Re-land 71230.
This restores 71230 which was reverted in 71252 by sheriff (to see if it was responsible for a linux test failure -- it was not).
Original change by alekseys:
Streamline the layout of the BrowserView's children TabContents views.
Modify SingleSplitView to calculate its children view's bounds, but do not actually resize them
and change BrowserViewLayout accordingly (BrowserViewLayout resizes all views now).
Do all reserved contents rect calculations before resizing TabContents views.
Rationale: to do all BrowserView layout related actions in the context of
BrowserViewLayout::Layout call and to minimize actual contents re-layouts.
BUG= 51084
TEST=All tests should pass
Review URL: http://codereview.chromium.org/5606012
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71259
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+509 lines, -156 lines) |
Patch |
|
M |
chrome/browser/ui/views/frame/browser_view.h
|
View
|
|
6 chunks |
+8 lines, -4 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/views/frame/browser_view.cc
|
View
|
|
11 chunks |
+23 lines, -47 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/views/frame/browser_view_layout.h
|
View
|
|
3 chunks |
+15 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/ui/views/frame/browser_view_layout.cc
|
View
|
|
3 chunks |
+109 lines, -4 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/views/tab_contents/tab_contents_container.h
|
View
|
|
4 chunks |
+8 lines, -20 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/views/tab_contents/tab_contents_container.cc
|
View
|
|
7 chunks |
+18 lines, -22 lines |
0 comments
|
Download
|
|
M |
chrome/chrome_tests.gypi
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
|
M |
views/controls/single_split_view.h
|
View
|
|
5 chunks |
+52 lines, -6 lines |
0 comments
|
Download
|
|
M |
views/controls/single_split_view.cc
|
View
|
|
6 chunks |
+96 lines, -51 lines |
0 comments
|
Download
|
|
A |
views/controls/single_split_view_unittest.cc
|
View
|
1
|
1 chunk |
+176 lines, -0 lines |
0 comments
|
Download
|
|
M |
views/examples/single_split_view_example.h
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
|
M |
views/views.gyp
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
Total messages: 2 (0 generated)
|