Add test framework for bmpblk_utility.

Add test framework for bmpblk_utility.

BUG=chromium-os:11742
TEST=manual

Check out sources, run:

  cd src/platform/vboot_reference
  make
  make runbmptests

It should pass.

Change-Id: I50ebdef26662e7446828315a3f5e2786624508b9

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=856e072

[Randall Spangler, 2011-02-07 22:40:31]

http://codereview.chromium.org/6246150/diff/1/tests/bitmaps/TestBmpBlock.py
File tests/bitmaps/TestBmpBlock.py (right):

http://codereview.chromium.org/6246150/diff/1/tests/bitmaps/TestBmpBlock.py#n...
tests/bitmaps/TestBmpBlock.py:13: p = subprocess.Popen(*args,
stdout=subprocess.PIPE, stderr=subprocess.PIPE)
Since args is already a list, just call Popen(args, ...)

http://codereview.chromium.org/6246150/diff/1/tests/bitmaps/TestBmpBlock.py#n...
tests/bitmaps/TestBmpBlock.py:14: rc = p.wait()
If you p.wait() before you p.communicate(), you can fill up the pipe with too
much output and hang.

You can skip the wait; p.communicate() blocks.

See: http://docs.python.org/release/2.6.4/library/subprocess.html#popen-objects

http://codereview.chromium.org/6246150/diff/1/tests/bitmaps/TestBmpBlock.py#n...
tests/bitmaps/TestBmpBlock.py:16: return (rc, out, err)
(p.returncode, out, err)

http://codereview.chromium.org/6246150/diff/1/tests/bitmaps/TestBmpBlock.py#n...
tests/bitmaps/TestBmpBlock.py:23: rc, out, err = runprog([prog])
You're using *args above, so should be able to call runprog(prog).

http://codereview.chromium.org/6246150/diff/1/tests/bitmaps/TestBmpBlock.py#n...
tests/bitmaps/TestBmpBlock.py:29: rc, out, err = runprog([prog, '-c', '-C',
'case_nobmp.yaml', 'FOO'])
runprog(prog, '-c', ...)

Don't need the extra []

http://codereview.chromium.org/6246150/diff/1/tests/bitmaps/TestBmpBlock.py#n...
tests/bitmaps/TestBmpBlock.py:45: print "prog is", prog
leftover debugging?

Could also do:

if varname not in os.environ:
  print 'Blargh!'
  sys.exit(1)

http://codereview.chromium.org/6246150/diff/1/tests/bitmaps/TestBmpBlock.py#n...
tests/bitmaps/TestBmpBlock.py:47: print 'You must specify the path to
bmpbpk_utility in the $' + \
Tidier (and a bit safer) to use %s:

print ('You must specify the path to bmpbpk_utility in the'      
       ' $%s environment variable' % varname)

(putting the arg to print in () causes string concatenation to apply... take out
the () to see an error... :)

[Randall Spangler, 2011-02-07 23:38:35]

LGTM assuming typo fixed

http://codereview.chromium.org/6246150/diff/4001/tests/bitmaps/TestBmpBlock.py
File tests/bitmaps/TestBmpBlock.py (right):

http://codereview.chromium.org/6246150/diff/4001/tests/bitmaps/TestBmpBlock.p...
tests/bitmaps/TestBmpBlock.py:43: print('You must specify the path to
bmpbpk_utility in the $%s '
bmpblk?