Switch from v_info logging to debug

Switch from v_info logging to debug

Change-Id: I9a3177bf295462d40a6e7045a2ffb793bbfe3166

BUG=chromium-os:11672
TEST=Manual

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=a0e7ea1

[dgarrett, 2011-02-07 22:06:50]

Fixed sandbox issue.

[diandersAtChromium, 2011-02-07 22:29:18]

LGTM w/ request to take kliegs advice and make it an error if ${CHROME_ROOT}/src
is defined but doesn't exist.

http://codereview.chromium.org/6246148/diff/3001/enter_chroot.sh
File enter_chroot.sh (right):

http://codereview.chromium.org/6246148/diff/3001/enter_chroot.sh#newcode198
enter_chroot.sh:198: if [[ ( -z "$CHROME_ROOT" ) || ( ! -d "${CHROME_ROOT}/src"
) ]]; then
Should probably split into two cases.  The "-z" case should be debug.  The "!
-d" case should be error.

[dgarrett, 2011-02-07 22:54:04]

That bit's more tricky that it looked at first. CHROME_ROOT can either come
from a command line, or preserved from a previous specification. Proper
handling in all cases gets a big weird and needs reworking.

On Mon, Feb 7, 2011 at 2:29 PM, <dianders@chromium.org> wrote:

> LGTM w/ request to take kliegs advice and make it an error if
> ${CHROME_ROOT}/src
> is defined but doesn't exist.
>
>
> http://codereview.chromium.org/6246148/diff/3001/enter_chroot.sh
> File enter_chroot.sh (right):
>
> http://codereview.chromium.org/6246148/diff/3001/enter_chroot.sh#newcode198
> enter_chroot.sh:198: if [[ ( -z "$CHROME_ROOT" ) || ( ! -d
> "${CHROME_ROOT}/src" ) ]]; then
> Should probably split into two cases.  The "-z" case should be debug.
> The "! -d" case should be error.
>
>
> http://codereview.chromium.org/6246148/
>



-- 
Don

[dgarrett, 2011-02-08 02:09:44]

On 2011/02/08 00:10:39, dgarrett wrote:

PTAL, I think I have the full answer.

Please remember that this script will probably only live a few more weeks.

[diandersAtChromium, 2011-02-08 02:35:12]

LGTM w/ nits.

http://codereview.chromium.org/6246148/diff/3005/enter_chroot.sh
File enter_chroot.sh (right):

http://codereview.chromium.org/6246148/diff/3005/enter_chroot.sh#newcode203
enter_chroot.sh:203: if [[ ! "$CHROME_ROOT_AUTO" ]]; then
It is only a fatal error if user specified in the command line.

...if user didn't specify it in the command line, it will be a non-fatal error
(and the file will be deleted, so things will work next time).

http://codereview.chromium.org/6246148/diff/3005/enter_chroot.sh#newcode208
enter_chroot.sh:208: sudo bash -c "echo $CHROME_ROOT > \
nit: Should put quotes around $CHROME_ROOT, just to be safe.

http://codereview.chromium.org/6246148/diff/3005/enter_chroot.sh#newcode209
enter_chroot.sh:209: ${FLAGS_chroot}${CHROME_ROOT_CONFIG}"
nite: ...and probably quotes here, too?

[dgarrett, 2011-02-08 02:40:55]

http://codereview.chromium.org/6246148/diff/3005/enter_chroot.sh
File enter_chroot.sh (right):

http://codereview.chromium.org/6246148/diff/3005/enter_chroot.sh#newcode203
enter_chroot.sh:203: if [[ ! "$CHROME_ROOT_AUTO" ]]; then
Right. As best as I can figure out, this is as designed. There is no command
line for clearing the remembered CHROME_ROOT value.

On 2011/02/08 02:35:13, diandersAtChromium wrote:
> It is only a fatal error if user specified in the command line.
> 
> ...if user didn't specify it in the command line, it will be a non-fatal error
> (and the file will be deleted, so things will work next time).

http://codereview.chromium.org/6246148/diff/3005/enter_chroot.sh#newcode208
enter_chroot.sh:208: sudo bash -c "echo $CHROME_ROOT > \
On 2011/02/08 02:35:13, diandersAtChromium wrote:
> nit: Should put quotes around $CHROME_ROOT, just to be safe.

Done.

http://codereview.chromium.org/6246148/diff/3005/enter_chroot.sh#newcode209
enter_chroot.sh:209: ${FLAGS_chroot}${CHROME_ROOT_CONFIG}"
On 2011/02/08 02:35:13, diandersAtChromium wrote:
> nite: ...and probably quotes here, too?

Done.

[kliegs, 2011-02-08 15:48:03]

Thanks very much for making these changes.  Sorry I took so long to get to this,
was out sick yesterday and still a bit slow today.  

I'm not sure how I feel about the chrome mounting logic.  I think the way you
implemented is fine and don't think you should change anything, but I'm not sure
the logic as a whole (sticky mount points and failing only on the explicit
mount).  But that's outside this CL and if chromite solves the problem in a
better way its probably not worth fixing.  Mainly just mentioning this as a
reminder for the future.

http://codereview.chromium.org/6246148/diff/9001/enter_chroot.sh
File enter_chroot.sh (right):

http://codereview.chromium.org/6246148/diff/9001/enter_chroot.sh#newcode291
enter_chroot.sh:291: debug "tearing down env."
I'd still like to see this remain a warning.  While I've seen cases where it
isn't needed, I've seen enough where it is useful (buildbot debugging mainly)
that I think it adds value. 

Are there that many cases where people are in the chroot in multiple sessions
that this warning is too noisy?