Test Autofill's ability to merge duplicate profiles and...

chrome/test/functional/autofill.py

Index: chrome/test/functional/autofill.py
===================================================================
--- chrome/test/functional/autofill.py	(revision 75303)
+++ chrome/test/functional/autofill.py	(working copy)
@@ -3,8 +3,11 @@
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
+import logging
 import os
+import pickle
 
+import dataset_converter
 import pyauto_functional  # Must be imported before pyauto
 import pyauto
 
@@ -93,10 +96,63 @@
     self.assertEqual([expected_credit_card],
                      self.GetAutoFillProfile()['credit_cards'])
 
-  def testAutofillCrowdSourcing(self):
-    """Test able to send POST request of web form to crowd source server.
-    Require a loop of 1000 submits as the source server only collects 1% of
-    the data posted."""
+  def testFilterIncompleteAddresses(self):
+    """Test Autofill filters out profile with incomplete address info."""
+    profile = {'NAME_FIRST': 'Bob',
+               'NAME_LAST': 'Smith',
+               'EMAIL_ADDRESS': 'bsmith@example.com',
+               'COMPANY_NAME': 'Company X',
+               'PHONE_HOME_WHOLE_NUMBER': '650-123-4567',}
+    url = self.GetHttpURLForDataPath(
+        os.path.join('autofill', 'dup-profiles-test.html'))
+    self.NavigateToURL(url)
+    for key, value in profile.iteritems():
+      script = ('document.getElementById("%s").value = "%s"; '
+                'window.domAutomationController.send("done");') % (key, value)
+      self.ExecuteJavascript(script, 0, 0)
+    js_code = """
+      document.getElementById("merge_dup").submit();
+      window.addEventListener("unload", function() {
+        window.domAutomationController.send("done");
+      });
+    """
+    self.ExecuteJavascript(js_code, 0, 0)
+    self.assertEqual([], self.GetAutoFillProfile()['profiles'])
+
+  def testFilterMalformedEmailAddresses(self):
+    """Test Autofill filters out malformed email address during form submit."""
+    profile = {'NAME_FIRST': 'Bob',
+               'NAME_LAST': 'Smith',
+               'EMAIL_ADDRESS': 'garbage',
+               'ADDRESS_HOME_LINE1': '1234 H St.',
+               'ADDRESS_HOME_CITY': 'San Jose',
+               'ADDRESS_HOME_STATE': 'CA',
+               'ADDRESS_HOME_ZIP': '95110',
+               'COMPANY_NAME': 'Company X',
+               'PHONE_HOME_WHOLE_NUMBER': '408-123-4567',}
+    url = self.GetHttpURLForDataPath(
+        os.path.join('autofill', 'dup-profiles-test.html'))
+    self.NavigateToURL(url)
+    for key, value in profile.iteritems():
+      script = ('document.getElementById("%s").value = "%s"; '
+                'window.domAutomationController.send("done");') % (key, value)
+      self.ExecuteJavascript(script, 0, 0)
+    js_code = """
+      document.getElementById("merge_dup").submit();
+      window.addEventListener("unload", function() {
+        window.domAutomationController.send("done");
+      });
+    """
+    self.ExecuteJavascript(js_code, 0, 0)
+    if 'EMAIL_ADDRESS' in self.GetAutoFillProfile()['profiles'][0]:
+      raise KeyError('TEST FAIL: Malformed email address is saved in profiles.')
+
+  def testAutofillCrowdsourcing(self):
+    """Test able to send POST request of web form to Autofill server.
+
+    The Autofill server processes the data offline, so it can take a few days
+    for the result to be detectable. Manual verification is required.
+    """
     # HTML file needs to be run from a specific http:// url to be able to verify
     # the results a few days later by visiting the same url.
     url = 'http://www.corp.google.com/~dyu/autofill/crowdsourcing-test.html'
@@ -105,25 +161,61 @@
                              'crowdsource_autofill.txt')
     profiles = self.EvalDataFrom(file_path)
     self.FillAutoFillProfile(profiles=profiles)
+    # Autofill server captures 2.5% of the data posted.
+    # Looping 1000 times is a safe minimum to exceed the server's threshold or
+    # noise.
     for i in range(1000):
       fname = self.GetAutoFillProfile()['profiles'][0]['NAME_FIRST']
       lname = self.GetAutoFillProfile()['profiles'][0]['NAME_LAST']
       email = self.GetAutoFillProfile()['profiles'][0]['EMAIL_ADDRESS']
       # Submit form to collect crowdsourcing data for Autofill.
       self.NavigateToURL(url, 0, 0)
-      fname_field = 'document.getElementById("fn").value = "%s"; ' \
-                    'window.domAutomationController.send("done")' % fname
-      lname_field = 'document.getElementById("ln").value = "%s"; ' \
-                    'window.domAutomationController.send("done")' % lname
-      email_field = 'document.getElementById("em").value = "%s"; ' \
-                    'window.domAutomationController.send("done")' % email
+      fname_field = ('document.getElementById("fn").value = "%s"; '
+                     'window.domAutomationController.send("done");') % fname
+      lname_field = ('document.getElementById("ln").value = "%s"; '
+                     'window.domAutomationController.send("done");') % lname
+      email_field = ('document.getElementById("em").value = "%s"; '
+                     'window.domAutomationController.send("done");') % email
       self.ExecuteJavascript(fname_field, 0, 0);
       self.ExecuteJavascript(lname_field, 0, 0);
       self.ExecuteJavascript(email_field, 0, 0);
       self.ExecuteJavascript('document.getElementById("frmsubmit").submit();'
-                             'window.domAutomationController.send("done")',
+                             'window.domAutomationController.send("done");',
                              0, 0)
 
+  def testMergeDuplicateProfilesInAutofill(self):
+    """Test Autofill ability to merge duplicate profiles and throw away junk."""
+    # HTML file needs to be run from a http:// url.
+    url = self.GetHttpURLForDataPath(
+        os.path.join('autofill', 'duplicate_profiles_test.html'))
+    # Run the parser script to generate the dictionary list needed for the
+    # profiles.
+    c = dataset_converter.DatasetConverter(
+        os.path.join(self.DataDir(), 'autofill', 'dataset.txt'),
+        logging_level = logging.INFO) # Set verbosity to INFO, WARNING, ERROR.

[dennis_jeffrey, 2011/02/17 22:58:35]

Remove the spaces around the "=" in this line.  The python style guide says
"Don't use spaces around the '=' sign when used to indicate a keyword argument
or a default parameter value."

[dennis_jeffrey, 2011/02/17 22:58:35]

I think we can remove this comment, since the code is always using
"logging.INFO" as the verbosity here (not WARNING or ERROR).  But if you'd
prefer to leave the comment, add one more space before the comment starts; the
style guide says this about inline comments: "To improve legibility, these
comments should be at least 2 spaces away from the code."

[dyu1, 2011/02/18 00:31:47]

Done.

[dyu1, 2011/02/18 00:31:47]

I prefer to keep the comment for future ref.

On 2011/02/17 22:58:35, dennis_jeffrey wrote:

+    list_of_dict = c.Convert()
 
+    for profile in list_of_dict:
+      self.NavigateToURL(url)
+      for key, value in profile.iteritems():
+        script = ('document.getElementById("%s").value = "%s"; '
+                  'window.domAutomationController.send("done");') % (key, value)
+        self.ExecuteJavascript(script, 0, 0)
+      self.ExecuteJavascript('document.getElementById("merge_dup").submit();'
+                             'window.domAutomationController.send("done");',
+                             0, 0)
+    # Verify total number of inputted profiles is greater than the final number
+    # of profiles after merging.
+    self.assertTrue(
+        len(list_of_dict) > len(self.GetAutoFillProfile()['profiles']))
+    # Write profile dictionary to a file.
+    merged_profile = os.path.join(self.DataDir(), 'autofill',
+                                  'merged-profiles.txt')
+    profile_dict = self.GetAutoFillProfile()['profiles']
+    output = open(merged_profile, 'wb')
+    pickle.dump(profile_dict, output)
+    output.close()
+
+
 if __name__ == '__main__':
   pyauto_functional.Main()