Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Issue 6246141: autotest: use installed version of cros_workon (Closed)

Created:
9 years, 10 months ago by Mandeep Singh Baines
Modified:
9 years, 7 months ago
Reviewers:
robotboy, anush
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Visibility:
Public.

Description

autotest: use installed version of cros_workon BUG=11507 TEST=Ran run_remote_test.sh and verified that the following is printed: INFO : Detected cros_workon autotests. Building and running your autotests from /home/msb/trunk/src/third_party/autotest/files. To use emerged autotest, pass --use_emerged. Change-Id: Ifc4305088e4edd059fad250d074347bc81a451cf Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=fa42b03

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M run_remote_tests.sh View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Mandeep Singh Baines
9 years, 10 months ago (2011-02-07 16:33:16 UTC) #1
anush
9 years, 10 months ago (2011-02-07 16:37:51 UTC) #2
LGTM

On Mon, Feb 7, 2011 at 8:33 AM,  <msb@chromium.org> wrote:
> Reviewers: anush, robotboy,
>
> Description:
> autotest: use installed version of cros_workon
>
> BUG=11507
> TEST=Ran run_remote_test.sh and verified that the following is printed:
>
> INFO   : Detected cros_workon autotests. Building and running your autotests
> from /home/msb/trunk/src/third_party/autotest/files. To use emerged
> autotest,
> pass --use_emerged.
>
> Change-Id: Ifc4305088e4edd059fad250d074347bc81a451cf
>
> Please review this at http://codereview.chromium.org/6246141/
>
> SVN Base: http://git.chromium.org/git/crosutils.git@master
>
> Affected files:
>  M run_remote_tests.sh
>
>
> Index: run_remote_tests.sh
> diff --git a/run_remote_tests.sh b/run_remote_tests.sh
> index
>
cb007c060b9bc03ee947109e923810f5fb2dc069..f1f49cfe18426dcb246241d37b19ba0a62e07e02
> 100755
> --- a/run_remote_tests.sh
> +++ b/run_remote_tests.sh
> @@ -148,7 +148,7 @@ autotest autotest-tests (or use --build)."
>   fi
>
>   if [ ${FLAGS_build} -eq ${FLAGS_FALSE} ] &&
> -      "${SCRIPTS_DIR}/cros_workon" --board=${FLAGS_board} list |
> +      cros_workon --board=${FLAGS_board} list |
>       grep -q autotest; then
>     AUTOTEST_DIR="${SRC_ROOT}/third_party/autotest/files"
>     FLAGS_build=${FLAGS_TRUE}
>
>
>

Powered by Google App Engine
This is Rietveld 408576698