Issue 6246055: Do proper security checks when accessing elements with getOwnPropertyDescriptor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6246055: Do proper security checks when accessing elements with getOwnPropertyDescriptor. (Closed)

Created:
9 years, 10 months ago by antonm

Modified:
9 years, 4 months ago

Reviewers:
Rico, Mads Ager (chromium)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Do proper security checks when accessing elements with getOwnPropertyDescriptor. This extends logic applied to regular properties to elements. Committed: http://code.google.com/p/v8/source/detail?r=6626

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressing Mads' comment #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+109 lines, -10 lines)			Patch
	M	src/runtime.cc	View	1	5 chunks	+25 lines, -8 lines	0 comments	Download
	M	test/cctest/test-api.cc	View	1	5 chunks	+84 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

antonm

Mads and Rico, may you have a look? Changes in objects.cc and get-own-property-descriptor.js are from ...

9 years, 10 months ago (2011-02-02 20:41:13 UTC) #1

Mads Ager (chromium)

LGTM http://codereview.chromium.org/6246055/diff/1/src/runtime.cc File src/runtime.cc (right): http://codereview.chromium.org/6246055/diff/1/src/runtime.cc#newcode718 src/runtime.cc:718: // FIXME: we should traverse hidden prototype hierachy ...

9 years, 10 months ago (2011-02-03 08:14:26 UTC) #2

antonm

9 years, 10 months ago (2011-02-03 15:21:50 UTC) #3

http://codereview.chromium.org/6246055/diff/1/src/runtime.cc
File src/runtime.cc (right):

http://codereview.chromium.org/6246055/diff/1/src/runtime.cc#newcode718
src/runtime.cc:718: // FIXME: we should traverse hidden prototype hierachy as
well.
On 2011/02/03 08:14:26, Mads Ager wrote:
> Please file a bug and use TODO(bugnumber):

Done.

Expand Messages | Collapse Messages