Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2118)

Unified Diff: chrome/browser/printing/printing_layout_uitest.cc

Issue 6246036: FilePath: Remove most of ToWStringHack, adding a LossyDisplayName() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: bug link Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/plugin_service.cc ('k') | chrome/browser/process_singleton_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/printing/printing_layout_uitest.cc
diff --git a/chrome/browser/printing/printing_layout_uitest.cc b/chrome/browser/printing/printing_layout_uitest.cc
index 4f8ede16f16ed9217917b1016bfc4ed3c2a427dc..a3917c5d55844c9878d6a5ea06fcf63b2059d0ca 100644
--- a/chrome/browser/printing/printing_layout_uitest.cc
+++ b/chrome/browser/printing/printing_layout_uitest.cc
@@ -59,7 +59,7 @@ class PrintingLayoutTest : public PrintingTest<UITest> {
return 100.;
}
- std::wstring verification_file(test_data_directory_.ToWStringHack());
+ std::wstring verification_file(test_data_directory_.value());
file_util::AppendToPath(&verification_file, L"printing");
file_util::AppendToPath(&verification_file, verification_name);
FilePath emf(verification_file + L".emf");
@@ -143,22 +143,22 @@ class PrintingLayoutTest : public PrintingTest<UITest> {
prn_file.clear();
found_emf = false;
found_prn = false;
- std::wstring file;
- while (!(file = enumerator.Next().ToWStringHack()).empty()) {
- std::wstring ext = FilePath(file).Extension();
+ FilePath file;
+ while (!(file = enumerator.Next()).empty()) {
+ std::wstring ext = file.Extension();
if (base::strcasecmp(WideToUTF8(ext).c_str(), ".emf") == 0) {
EXPECT_FALSE(found_emf) << "Found a leftover .EMF file: \"" <<
- emf_file << "\" and \"" << file << "\" when looking for \"" <<
- verification_name << "\"";
+ emf_file << "\" and \"" << file.value() <<
+ "\" when looking for \"" << verification_name << "\"";
found_emf = true;
- emf_file = file;
+ emf_file = file.value();
continue;
}
if (base::strcasecmp(WideToUTF8(ext).c_str(), ".prn") == 0) {
EXPECT_FALSE(found_prn) << "Found a leftover .PRN file: \"" <<
- prn_file << "\" and \"" << file << "\" when looking for \"" <<
- verification_name << "\"";
- prn_file = file;
+ prn_file << "\" and \"" << file.value() <<
+ "\" when looking for \"" << verification_name << "\"";
+ prn_file = file.value();
found_prn = true;
file_util::Delete(file, false);
continue;
« no previous file with comments | « chrome/browser/plugin_service.cc ('k') | chrome/browser/process_singleton_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698