Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(891)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/test/plugin/pdf_browsertest.cc

Issue 6246036: FilePath: Remove most of ToWStringHack, adding a LossyDisplayName() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/common/extensions/extension.cc ('K') | « chrome/test/mini_installer_test/chrome_mini_installer.cc ('k') | chrome/test/ui/ui_layout_test.cc » ('j') | webkit/database/database_tracker.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/plugin/pdf_browsertest.cc
diff --git a/chrome/test/plugin/pdf_browsertest.cc b/chrome/test/plugin/pdf_browsertest.cc
index 31cb073ce480012cec6ac0cee09764fe77315ace..127b8053875d4f75a5fd4c673dc943d1126dddcc 100644
--- a/chrome/test/plugin/pdf_browsertest.cc
+++ b/chrome/test/plugin/pdf_browsertest.cc
@@ -304,7 +304,8 @@ IN_PROC_BROWSER_TEST_F(PDFBrowserTest, Loading) {
for (FilePath file_path = file_enumerator.Next();
!file_path.empty();
file_path = file_enumerator.Next()) {
- std::string filename = WideToASCII(file_path.BaseName().ToWStringHack());
+ std::string filename =
+ UTF16ToASCII(file_path.BaseName().LossyDisplayName());
Mark Mentovai 2011/02/01 22:54:55 To ASCII? Hmm.
#if defined(OS_MACOSX) || defined(OS_LINUX)
if (filename == "sample.pdf")
« chrome/common/extensions/extension.cc ('K') | « chrome/test/mini_installer_test/chrome_mini_installer.cc ('k') | chrome/test/ui/ui_layout_test.cc » ('j') | webkit/database/database_tracker.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698