Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Unified Diff: tko/parsers/version_1_unittest.py

Issue 6246035: Merge remote branch 'cros/upstream' into master (Closed) Base URL: ssh://git@gitrw.chromium.org:9222/autotest.git@master
Patch Set: patch Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tko/parsers/version_1_unittest.py
diff --git a/tko/parsers/version_1_unittest.py b/tko/parsers/version_1_unittest.py
index 72444c5eb3971b6eeb3dbe514511fad96eaab6f7..4114c59cc9415ec93f46c9ae3d023f04a8687b2f 100755
--- a/tko/parsers/version_1_unittest.py
+++ b/tko/parsers/version_1_unittest.py
@@ -220,8 +220,8 @@ class iteration_parse_line_into_dicts(unittest.TestCase):
def test_perf_entry(self):
- result = self.parse_line("perf-val{perf}=173")
- self.assertEqual(({}, {"perf-val": 173}), result)
+ result = self.parse_line("perf-val{perf}=-173")
+ self.assertEqual(({}, {"perf-val": -173}), result)
def test_attr_entry(self):
@@ -230,8 +230,8 @@ class iteration_parse_line_into_dicts(unittest.TestCase):
def test_untagged_is_perf(self):
- result = self.parse_line("untagged=678.5")
- self.assertEqual(({}, {"untagged": 678.5}), result)
+ result = self.parse_line("untagged=-678.5e5")
+ self.assertEqual(({}, {"untagged": -678.5e5}), result)
def test_invalid_tag_ignored(self):
@@ -240,12 +240,12 @@ class iteration_parse_line_into_dicts(unittest.TestCase):
def test_non_numeric_perf_ignored(self):
- result = self.parse_line("perf-val{perf}=NaN")
+ result = self.parse_line("perf-val{perf}=FooBar")
self.assertEqual(({}, {}), result)
def test_non_numeric_untagged_ignored(self):
- result = self.parse_line("untagged=NaN")
+ result = self.parse_line("untagged=FooBar")
self.assertEqual(({}, {}), result)
« cli/job.py ('K') | « tko/parsers/version_1.py ('k') | utils/check_patch.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698