Issue 6246017: Fix memory leaks in BufferedDataSource, BufferedResourceLoader and SimpleDataSource unit tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6246017: Fix memory leaks in BufferedDataSource, BufferedResourceLoader and SimpleDataSource unit tests. (Closed)

Created:
9 years, 11 months ago by scherkus (not reviewing)

Modified:
9 years, 7 months ago

Reviewers:
Lei Zhang

CC:
chromium-reviews, vrk (LEFT CHROMIUM), Alexander Potapenko, sjl, ddorwin+watch_chromium.org, Alpha Left Google, Timur Iskhodzhanov, acolwell GONE FROM CHROMIUM, annacc, pam+watch_chromium.org, awong, Paweł Hajdan Jr., darin-cc_chromium.org, stuartmorgan+watch_chromium.org, scherkus (not reviewing)

Base URL:
svn://chrome-svn/chrome/trunk/src

Visibility:
Public.

Description

Fix memory leaks in BufferedDataSource, BufferedResourceLoader and SimpleDataSource unit tests. BUG=65664 TEST=test_shell_tests + valgrind/heapcheck Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72316

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -57 lines)			Patch
M	tools/heapcheck/suppressions.txt	View	1 chunk	+0 lines, -24 lines	0 comments	Download
M	tools/valgrind/memcheck/suppressions.txt	View	2 chunks	+0 lines, -29 lines	0 comments	Download
M	webkit/glue/media/buffered_data_source_unittest.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	webkit/glue/media/buffered_resource_loader_unittest.cc	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	webkit/glue/media/simple_data_source_unittest.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

scherkus (not reviewing)

Guess we shouldn't have been ignoring those results! The tests don't need frame_ during tear ...

9 years, 11 months ago (2011-01-24 06:54:30 UTC) #1

LGTM

Expand Messages | Collapse Messages