Issue 6246011: DOMUI: Make the password input field readonly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6246011: DOMUI: Make the password input field readonly. (Closed)

Created:
9 years, 11 months ago by James Hawkins

Modified:
9 years, 7 months ago

Reviewers:
stuartmorgan

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

DOMUI: Make the password input field readonly. BUG=70006, 70039 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71899

Patch Set 3 : Simplification. #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -3 lines)			Patch
	M	chrome/browser/resources/options/password_manager_list.js	View	1 2	2 chunks	+6 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

James Hawkins

Can you take another look? I fixed a bug that made it impossible to delete ...

9 years, 11 months ago (2011-01-20 01:49:08 UTC) #3

stuartmorgan

SLGTM http://codereview.chromium.org/6246011/diff/4001/chrome/browser/resources/options/password_manager_list.js File chrome/browser/resources/options/password_manager_list.js (right): http://codereview.chromium.org/6246011/diff/4001/chrome/browser/resources/options/password_manager_list.js#newcode72 chrome/browser/resources/options/password_manager_list.js:72: var input = passwordInput != undefined ? passwordInput ...

9 years, 11 months ago (2011-01-20 01:52:48 UTC) #4

James Hawkins

9 years, 11 months ago (2011-01-20 01:54:55 UTC) #5

http://codereview.chromium.org/6246011/diff/4001/chrome/browser/resources/opt...
File chrome/browser/resources/options/password_manager_list.js (right):

http://codereview.chromium.org/6246011/diff/4001/chrome/browser/resources/opt...
chrome/browser/resources/options/password_manager_list.js:72: var input =
passwordInput != undefined ? passwordInput : textInput;
On 2011/01/20 01:52:48, stuartmorgan wrote:
> I believe in JS you can just do:
> var input = passwordInput || textInput

Done.

Expand Messages | Collapse Messages

Issue 6246011: DOMUI: Make the password input field readonly. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Delete fix. #

Patch Set 3 : Simplification. #

Messages